Bug 70637 – webkitpy: Teach NRWT about the EFL port

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Leandro Pereira]

webkitpy: Teach NRWT about the EFL port

[Leandro Pereira]

Created attachment 112010 [details]
Patch

[WebKit Review Bot]

Attachment 112010 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1

Tools/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Comment on attachment 112010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112010&action=review

LGTM, except it can't work as-is due to the factory.py typo.

> Tools/Scripts/webkitpy/layout_tests/port/efl.py:70
> +        return static_path if os.path.isfile(static_path) else dyn_path

This should use self._filesystem.exists instead.

> Tools/Scripts/webkitpy/layout_tests/port/factory.py:111
> +            maker = qt.EflPort

You mean efl.EflPort

[Leandro Pereira]

Created attachment 112013 [details]
Patch

[Leandro Pereira]

(In reply to comment #3)(In reply to comment #3)
> 
> LGTM, except it can't work as-is due to the factory.py typo.
> 

Thanks -- submitted a new patch.

[Eric Seidel (no email)]

Comment on attachment 112013 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112013&action=review

Seems reasonable.

> Tools/Scripts/webkitpy/layout_tests/port/efl.py:45
> +        self._version = self.port_name

This seems odd.  Why is this needed?

[Leandro Pereira]

(In reply to comment #6)
> (From update of attachment 112013 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=112013&action=review
> 
> Seems reasonable.
> 
> > Tools/Scripts/webkitpy/layout_tests/port/efl.py:45
> > +        self._version = self.port_name
> 
> This seems odd.  Why is this needed?
>

This identifies the version of the platform (e.g. 'xp', 'snow-leopard') and is used to choose which test expectations to parse (among other things). Since there's only one supported version, this is being set to the port name; GTK also does this.

[WebKit Review Bot]

Comment on attachment 112013 [details]
Patch

Clearing flags on attachment: 112013

Committed r98157: <http://trac.webkit.org/changeset/98157>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.