Bug 70625 - check-webkit-style: Allow names starting with "_q_" used by Qt for private slots.
Summary: check-webkit-style: Allow names starting with "_q_" used by Qt for private sl...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-21 11:15 PDT by Jocelyn Turcotte
Modified: 2011-11-01 04:36 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.29 KB, patch)
2011-10-21 11:16 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2011-10-21 11:15:12 PDT
check-webkit-style: Allow names starting with "_q_" used by Qt for private slots.
Comment 1 Jocelyn Turcotte 2011-10-21 11:16:32 PDT
Created attachment 111992 [details]
Patch
Comment 2 Tor Arne Vestbø 2011-10-21 11:20:59 PDT
Comment on attachment 111992 [details]
Patch

lgtm
Comment 3 WebKit Review Bot 2011-10-21 11:23:17 PDT
Comment on attachment 111992 [details]
Patch

Rejecting attachment 111992 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Last 500 characters of output:
cripts/webkitpy/common/system/executive.py", line 420, in run_command
    close_fds=self._should_close_fds())
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen
    return subprocess.Popen(*args, **kwargs)
  File "/usr/lib/python2.6/subprocess.py", line 623, in __init__
    errread, errwrite)
  File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child
    raise child_exception
TypeError: execv() arg 2 must contain only strings

Full output: http://queues.webkit.org/results/10180981
Comment 4 Jocelyn Turcotte 2011-11-01 04:36:30 PDT
Comment on attachment 111992 [details]
Patch

Clearing flags on attachment: 111992

Committed r98950: <http://trac.webkit.org/changeset/98950>
Comment 5 Jocelyn Turcotte 2011-11-01 04:36:37 PDT
All reviewed patches have been landed.  Closing bug.