Bug 70618 – [chromium] Add isTraceEventEnabledForCategory to PlatformSupport.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nat Duca]

[chromium] Add isTraceEventEnabledForCategory to PlatformSupport.

[Nat Duca]

Created attachment 111985 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Nat Duca]

Created attachment 112011 [details]
Blanket enable instead of per-category

[Darin Fisher (:fishd, Google)]

Comment on attachment 112011 [details]
Blanket enable instead of per-category

View in context: https://bugs.webkit.org/attachment.cgi?id=112011&action=review

> Source/WebKit/chromium/public/WebKitPlatformSupport.h:233
> +    virtual bool isTraceEventEnabled() const { return true; }

actually, are you sure you don't want to invert this?  it seems better to push
settings down into webkit instead of making webkit ask the embedder each and
every time via a virtual function call.  most other things like this work by
pushing a setting down into WebKit.  see for example WebKit::setLayoutTestMode
or WebKit::WebSecurityPolicy.

perhaps this could be a method in WebKit.h?  setTraceEventEnabled(bool)?

it seems like a corresponding method could exist in TraceEvent.h.

[Nat Duca]

You're totally right about inverting it. I investigated this a bit further and I think I know how we should do it. Unfortunately, doing that inversion means we also have to switch from having traceBegin/traceEnd to the addTraceEvent style. I filed a bug to do this, and I'm going to beg jbates to do it. :)

https://bugs.webkit.org/show_bug.cgi?id=70761

[Nat Duca]

Committed r98282: <http://trac.webkit.org/changeset/98282>