Flash of white when loading a page after a web process crash

[Anders Carlsson]

Flash of white when loading a page after a web process crash

[Anders Carlsson]

Created attachment 111977 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 111977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111977&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2075
>  - (void)_didRelaunchProcess
>  {
> -    [self setNeedsDisplay:YES];
>  }

Can we remove this method entirely?

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:86
>  void DrawingAreaImpl::setNeedsDisplay(const IntRect& rect)
>  {
> +    if (!m_isPaintingEnabled)
> +        return;
> +
>      IntRect dirtyRect = rect;
>      dirtyRect.intersect(m_webPage->bounds());

Should we continue to accumulate a dirty region when painting is disabled so that the right area will be repainted when painting is reenabled?

> Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:109
>  void DrawingAreaImpl::scroll(const IntRect& scrollRect, const IntSize& scrollOffset)
>  {
> +    if (!m_isPaintingEnabled)
> +        return;
> +

Similar question here.

[Anders Carlsson]

(In reply to comment #2)
> (From update of attachment 111977 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111977&action=review
> 
> > Source/WebKit2/UIProcess/API/mac/WKView.mm:2075
> >  - (void)_didRelaunchProcess
> >  {
> > -    [self setNeedsDisplay:YES];
> >  }
> 
> Can we remove this method entirely?

Maybe.

> > Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:86
> >  void DrawingAreaImpl::setNeedsDisplay(const IntRect& rect)
> >  {
> > +    if (!m_isPaintingEnabled)
> > +        return;
> > +
> >      IntRect dirtyRect = rect;
> >      dirtyRect.intersect(m_webPage->bounds());
> 
> Should we continue to accumulate a dirty region when painting is disabled so that the right area will be repainted when painting is reenabled?

Nope - this is about disabling painting completely, not just suspending it.

> > Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp:109
> >  void DrawingAreaImpl::scroll(const IntRect& scrollRect, const IntSize& scrollOffset)
> >  {
> > +    if (!m_isPaintingEnabled)
> > +        return;
> > +
> 
> Similar question here.

Similar answer here.

[Simon Fraser (smfr)]

Comment on attachment 111977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111977&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:251
> +    m_drawingArea->setPaintingEnabled(true);

I sure hope we don't ever add an early return between setPaintingEnabled(false) and here.

[Anders Carlsson]

Committed r98113: <http://trac.webkit.org/changeset/98113>