Bug 70606 - [GTK] Missing DRT AccessibilityController::addNotificationListener implementation
Summary: [GTK] Missing DRT AccessibilityController::addNotificationListener implementa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joanmarie Diggs
URL:
Keywords: Gtk, LayoutTestFailure
: 73009 (view as bug list)
Depends on:
Blocks: 98347 98370
  Show dependency tree / graph
 
Reported: 2011-10-21 07:29 PDT by Philippe Normand
Modified: 2013-09-10 09:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.64 KB, patch)
2013-08-29 06:46 PDT, Denis Nomiyama (dnomi) 		no flags Details | Formatted Diff | Diff
Patch (3.85 KB, patch)
2013-09-10 07:47 PDT, Denis Nomiyama (dnomi) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2011-10-21 07:29:13 PDT 
accessibility/menu-list-sends-change-notification.html requires this feature.

Will skip the test for now.
Comment 1 Philippe Normand 2011-11-23 01:07:00 PST 
*** Bug 73009 has been marked as a duplicate of this bug. ***
Comment 2 Joanmarie Diggs 2012-12-09 17:02:13 PST 
Taking this one as it appears fixing it will make it possible to unskip quite a few tests.
Comment 3 Denis Nomiyama (dnomi) 2013-08-28 07:46:09 PDT 
I've raised a new bug 120419 for the problem reported at the description (menu-list-sends-change-notification.html) because it actually requires the implementation of AccessibilityUIElement::addNotificationListener(), which was done at bug 119883.
Comment 4 Denis Nomiyama (dnomi) 2013-08-29 06:46:55 PDT 
Created attachment 209971 [details]
Patch
Comment 5 Denis Nomiyama (dnomi) 2013-09-06 02:18:42 PDT 
Comment on attachment 209971 [details]
Patch

Some changes suggested in bug 120416 will affect the implementation of this patch. So I will re-work it after bug 120416 is resolved.
Comment 6 Denis Nomiyama (dnomi) 2013-09-10 07:47:57 PDT 
Created attachment 211201 [details]
Patch
Comment 7 Mario Sanchez Prada 2013-09-10 08:55:43 PDT 
Comment on attachment 211201 [details]
Patch

Lgtm
Comment 8 WebKit Commit Bot 2013-09-10 09:19:03 PDT 
Comment on attachment 211201 [details]
Patch

Clearing flags on attachment: 211201

Committed r155448: <http://trac.webkit.org/changeset/155448>
Comment 9 WebKit Commit Bot 2013-09-10 09:19:06 PDT 
All reviewed patches have been landed.  Closing bug.