Bug 70582 - REGRESSION(r92480): Passing uninitialized variable in HTMLElement::calculateAndAdjustDirectionality()
Summary: REGRESSION(r92480): Passing uninitialized variable in HTMLElement::calculateA...
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Kent Tamura
Keywords: Regression
Depends on:
Reported: 2011-10-20 22:33 PDT by Kent Tamura
Modified: 2011-10-22 03:52 PDT (History)
4 users (show)

See Also:

Patch (1.79 KB, patch)
2011-10-20 22:36 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-10-20 22:33:08 PDT
void HTMLElement::calculateAndAdjustDirectionality()
    Node* strongDirectionalityTextNode;
    TextDirection textDirection = directionality(&strongDirectionalityTextNode);
    setHasDirAutoFlagRecursively(this, true, strongDirectionalityTextNode);

The variable strongDirectionalityTextNode is not initialized by directionality() in a specific situation, and it is passed to setHasDirAutoFlagRecursively().
Comment 1 Kent Tamura 2011-10-20 22:34:21 PDT
This was found by Valgrind.
Comment 2 Kent Tamura 2011-10-20 22:36:38 PDT
Created attachment 111904 [details]
Comment 3 WebKit Review Bot 2011-10-22 03:52:51 PDT
Comment on attachment 111904 [details]

Clearing flags on attachment: 111904

Committed r98192: <http://trac.webkit.org/changeset/98192>
Comment 4 WebKit Review Bot 2011-10-22 03:52:56 PDT
All reviewed patches have been landed.  Closing bug.