RESOLVED FIXED 70568
Test that :visited style can be overridden by child element style 
https://bugs.webkit.org/show_bug.cgi?id=70568
Summary Test that :visited style can be overridden by child element style
Mike Lawther
Reported 2011-10-20 17:39:05 PDT
Test that unvisited link color is not used for an unvisited link
Attachments
Patch (2.76 KB, patch)
2011-10-20 17:41 PDT, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Patch (2.76 KB, patch)
2011-10-20 17:56 PDT, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Patch (2.86 KB, patch)
2011-10-21 08:38 PDT, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.31 KB, patch)
2011-10-27 17:10 PDT, Mike Lawther 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mike Lawther
Comment 1 2011-10-20 17:41:14 PDT
Created attachment 111880 [details] Patch
Mike Lawther
Comment 2 2011-10-20 17:53:54 PDT
Oops - I meant *visited* link color is not used for an unvisited link
Mike Lawther
Comment 3 2011-10-20 17:56:38 PDT
Created attachment 111883 [details] Patch
Antti Koivisto
Comment 4 2011-10-21 07:52:44 PDT
Comment on attachment 111883 [details] Patch The bug title and the text in the test itself (and really the test case file name too as this is about visited links, not unvisited) are incorrect. The case tests that :visited style can be overridden by child element style.
Antti Koivisto
Comment 5 2011-10-21 07:54:08 PDT
Note that <a href> is a link to the document itself and so is always considered visited.
Mike Lawther
Comment 6 2011-10-21 08:38:58 PDT
Created attachment 111970 [details] Patch
Mike Lawther
Comment 7 2011-10-21 08:40:45 PDT
Comment on attachment 111970 [details] Patch OK - I've fixed the description in the test and the ChangeLog, and updated the filename of the test.
Antti Koivisto
Comment 8 2011-10-21 10:48:28 PDT
Comment on attachment 111970 [details] Patch Thanks, r=me for the test. I set cq- though. As far as I understand this will require platform specific test results as render tree dumps will be different on other platforms. These results should probably be landed to somewhere in LayoutTests/platform/chromium*. Please verify that the test will not fail on any platforms when you land.
Mike Lawther
Comment 9 2011-10-26 17:21:20 PDT
I've tested on Chromium-Linux and added a result for that. I've updated LayoutTests/platform/chromium/test-expectations to expect Windows to fail and I'll rebaseline that after the bots cycle. I don't have access to any other builds for other ports (eg Qt) - how do I verify that the test will not fail on any platform before I land?
Mike Lawther
Comment 10 2011-10-27 17:10:15 PDT
Created attachment 112785 [details] Patch for landing
WebKit Review Bot
Comment 11 2011-10-27 18:02:01 PDT
Comment on attachment 112785 [details] Patch for landing Clearing flags on attachment: 112785 Committed r98673: <http://trac.webkit.org/changeset/98673>
WebKit Review Bot
Comment 12 2011-10-27 18:02:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.