Bug 70568 - Test that :visited style can be overridden by child element style
Summary: Test that :visited style can be overridden by child element style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Lawther
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-20 17:39 PDT by Mike Lawther
Modified: 2011-10-27 18:02 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.76 KB, patch)
2011-10-20 17:41 PDT, Mike Lawther
no flags Details | Formatted Diff | Diff
Patch (2.76 KB, patch)
2011-10-20 17:56 PDT, Mike Lawther
no flags Details | Formatted Diff | Diff
Patch (2.86 KB, patch)
2011-10-21 08:38 PDT, Mike Lawther
no flags Details | Formatted Diff | Diff
Patch for landing (5.31 KB, patch)
2011-10-27 17:10 PDT, Mike Lawther
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Lawther 2011-10-20 17:39:05 PDT
Test that unvisited link color is not used for an unvisited link
Comment 1 Mike Lawther 2011-10-20 17:41:14 PDT
Created attachment 111880 [details]
Patch
Comment 2 Mike Lawther 2011-10-20 17:53:54 PDT
Oops - I meant *visited* link color is not used for an unvisited link
Comment 3 Mike Lawther 2011-10-20 17:56:38 PDT
Created attachment 111883 [details]
Patch
Comment 4 Antti Koivisto 2011-10-21 07:52:44 PDT
Comment on attachment 111883 [details]
Patch

The bug title and the text in the test itself (and really the test case file name too as this is about visited links, not unvisited) are incorrect. The case tests that :visited style can be overridden by child element style.
Comment 5 Antti Koivisto 2011-10-21 07:54:08 PDT
Note that <a href> is a link to the document itself and so is always considered visited.
Comment 6 Mike Lawther 2011-10-21 08:38:58 PDT
Created attachment 111970 [details]
Patch
Comment 7 Mike Lawther 2011-10-21 08:40:45 PDT
Comment on attachment 111970 [details]
Patch

OK - I've fixed the description in the test and the ChangeLog, and updated the filename of the test.
Comment 8 Antti Koivisto 2011-10-21 10:48:28 PDT
Comment on attachment 111970 [details]
Patch

Thanks, r=me for the test.

I set cq- though. As far as I understand this will require platform specific test results as render tree dumps will be different on other platforms. These results should probably be landed to somewhere in LayoutTests/platform/chromium*. Please verify that the test will not fail on any platforms when you land.
Comment 9 Mike Lawther 2011-10-26 17:21:20 PDT
I've tested on Chromium-Linux and added a result for that. I've updated LayoutTests/platform/chromium/test-expectations to expect Windows to fail and I'll rebaseline that after the bots cycle.

I don't have access to any other builds for other ports (eg Qt) - how do I verify that the test will not fail on any platform before I land?
Comment 10 Mike Lawther 2011-10-27 17:10:15 PDT
Created attachment 112785 [details]
Patch for landing
Comment 11 WebKit Review Bot 2011-10-27 18:02:01 PDT
Comment on attachment 112785 [details]
Patch for landing

Clearing flags on attachment: 112785

Committed r98673: <http://trac.webkit.org/changeset/98673>
Comment 12 WebKit Review Bot 2011-10-27 18:02:07 PDT
All reviewed patches have been landed.  Closing bug.