WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70550
[Qt][WK2] qweberror* should follow the new file and class naming rules
https://bugs.webkit.org/show_bug.cgi?id=70550
Summary
[Qt][WK2] qweberror* should follow the new file and class naming rules
Jesus Sanchez-Palencia
Reported
2011-10-20 15:07:13 PDT
QWebError is not following the new file and class naming rules and should be refactored.
Attachments
Patch
(19.30 KB, patch)
2011-10-20 15:21 PDT
,
Jesus Sanchez-Palencia
noam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jesus Sanchez-Palencia
Comment 1
2011-10-20 15:07:34 PDT
(In reply to
comment #0
)
> QWebError is not following the new file and class naming rules and should be refactored.
The set of rules is defined at:
https://trac.webkit.org/wiki/QtWebKitHacking
Jesus Sanchez-Palencia
Comment 2
2011-10-20 15:21:33 PDT
Created
attachment 111855
[details]
Patch
Noam Rosenthal
Comment 3
2011-10-20 15:25:42 PDT
Comment on
attachment 111855
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=111855&action=review
> Source/WebKit2/ChangeLog:9 > + We have also merged QWebError and QWebErrorPrivate.
Nitpick: QWebErrorPrivate is now merged into QtWebError.
Jesus Sanchez-Palencia
Comment 4
2011-10-20 15:39:48 PDT
Committed
r98030
: <
http://trac.webkit.org/changeset/98030
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug