Bug 70550 - [Qt][WK2] qweberror* should follow the new file and class naming rules
Summary: [Qt][WK2] qweberror* should follow the new file and class naming rules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jesus Sanchez-Palencia
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-10-20 15:07 PDT by Jesus Sanchez-Palencia
Modified: 2011-10-20 15:39 PDT (History)
0 users

See Also:

Attachments
Patch (19.30 KB, patch)
2011-10-20 15:21 PDT, Jesus Sanchez-Palencia 		noam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2011-10-20 15:07:13 PDT 
QWebError is not following the new file and class naming rules and should be refactored.
Comment 1 Jesus Sanchez-Palencia 2011-10-20 15:07:34 PDT 
(In reply to comment #0)
> QWebError is not following the new file and class naming rules and should be refactored.

The set of rules is defined at: https://trac.webkit.org/wiki/QtWebKitHacking
Comment 2 Jesus Sanchez-Palencia 2011-10-20 15:21:33 PDT 
Created attachment 111855 [details]
Patch
Comment 3 Noam Rosenthal 2011-10-20 15:25:42 PDT 
Comment on attachment 111855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111855&action=review

> Source/WebKit2/ChangeLog:9
> +        We have also merged QWebError and QWebErrorPrivate.

Nitpick: QWebErrorPrivate is now merged into QtWebError.
Comment 4 Jesus Sanchez-Palencia 2011-10-20 15:39:48 PDT 
Committed r98030: <http://trac.webkit.org/changeset/98030>