RESOLVED FIXED 70548
Make WebCore depend on translator_glsl instead of translator_common 
https://bugs.webkit.org/show_bug.cgi?id=70548
Summary Make WebCore depend on translator_glsl instead of translator_common
Antoine Labour
Reported 2011-10-20 14:25:22 PDT
Make WebCore depend on translator_glsl instead of translator_common
Attachments
Patch (1.94 KB, patch)
2011-10-20 14:27 PDT, Antoine Labour 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Labour
Comment 1 2011-10-20 14:27:05 PDT
Created attachment 111849 [details] Patch
Antoine Labour
Comment 2 2011-10-20 14:29:23 PDT
This change is needed for landing http://codereview.appspot.com/5305052/ in ANGLE. Regardless, it's still the right thing to do, because translator_common is an incomplete library, it depends on symbols implemented in translator_glsl. In WebKit.gyp we also link translator_glsl which makes it work today. translator_glsl does depend on translator_common.
Kenneth Russell
Comment 3 2011-10-20 15:24:43 PDT
Comment on attachment 111849 [details] Patch Did you test against the current version of ANGLE, or do we need to roll forward the ANGLE DEPS in Chromium and then the Chromium revision in Source/WebKit/chromium/DEPS?
Antoine Labour
Comment 4 2011-10-20 16:46:09 PDT
AFAICT it works with the current version of ANGLE on linux, but I don't have a windows machine to test on.
Kenneth Russell
Comment 5 2011-10-20 17:15:00 PDT
(In reply to comment #4) > AFAICT it works with the current version of ANGLE on linux, but I don't have a windows machine to test on. I'm 99% sure this won't work on Windows, since Chrome depends on translator_hlsl on that platform, and we can't link in both. I'll test your patch there to verify.
Antoine Labour
Comment 6 2011-10-20 17:56:01 PDT
As discussed, I'm 99.9% sure we only directly depend on translator_glsl on all chrome platforms: - the code in WebCore asks for a GLSL translator - we already link translator_glsl in chrome - as you mention, we can't link in both translator_hlsl is only used inside of the ANGLE libGLESv2 (without its symbols being exported), but that should be independent.
Kenneth Russell
Comment 7 2011-10-20 18:15:11 PDT
Comment on attachment 111849 [details] Patch OK, I'd forgotten how this worked. Looks okay to me.
WebKit Review Bot
Comment 8 2011-10-20 19:29:16 PDT
Comment on attachment 111849 [details] Patch Clearing flags on attachment: 111849 Committed r98057: <http://trac.webkit.org/changeset/98057>
WebKit Review Bot
Comment 9 2011-10-20 19:29:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.