WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70541
There are two WebFrameLoadDelegatePrivate categories on NSObject
https://bugs.webkit.org/show_bug.cgi?id=70541
Summary
There are two WebFrameLoadDelegatePrivate categories on NSObject
Ian Henderson
Reported
2011-10-20 13:35:43 PDT
Attempting to include both <WebView/WebViewPrivate.h> and <WebView/WebFrameLoadDelegatePrivate.h> yields an error about duplicate categories. The two headers have conflicting definitions of NSObject (WebFrameLoadDelegatePrivate).
Attachments
proposed patch
(1.89 KB, patch)
2011-10-20 14:08 PDT
,
Ian Henderson
ddkilzer
: review+
ddkilzer
: commit-queue-
Details
Formatted Diff
Diff
proposed patch
(1.88 KB, patch)
2011-10-20 14:14 PDT
,
Ian Henderson
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ian Henderson
Comment 1
2011-10-20 14:08:36 PDT
Created
attachment 111847
[details]
proposed patch
David Kilzer (:ddkilzer)
Comment 2
2011-10-20 14:12:56 PDT
Comment on
attachment 111847
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=111847&action=review
r=me with those changes.
> Source/WebKit/mac/WebView/WebViewPrivate.h:703 > -@interface NSObject (WebFrameLoadDelegatePrivate) > +@interface NSObject (WebViewPrivateFrameLoadDelegate)
I think this should have "Private" at the end: WebViewFrameLoadDelegatePrivate.
WebKit Review Bot
Comment 3
2011-10-20 14:13:00 PDT
Attachment 111847
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/mac/WebView/WebViewPrivate.h:703: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit/mac/WebView/WebViewPrivate.h:721: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
David Kilzer (:ddkilzer)
Comment 4
2011-10-20 14:13:47 PDT
Comment on
attachment 111847
[details]
proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=111847&action=review
>> Source/WebKit/mac/WebView/WebViewPrivate.h:721 >> -@interface NSObject (WebResourceLoadDelegatePrivate) >> +@interface NSObject (WebViewPrivateResourceLoadDelegate) > > Extra space before ( in function call [whitespace/parens] [4]
This should have "Private" at the end as well: WebViewResourceLoadDelegatePrivate.
Ian Henderson
Comment 5
2011-10-20 14:14:12 PDT
Created
attachment 111848
[details]
proposed patch
David Kilzer (:ddkilzer)
Comment 6
2011-10-20 14:15:31 PDT
Comment on
attachment 111848
[details]
proposed patch r=me
WebKit Review Bot
Comment 7
2011-10-20 14:15:54 PDT
Attachment 111848
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/mac/ChangeLog', u'Source/Web..." exit_code: 1 Source/WebKit/mac/WebView/WebViewPrivate.h:703: Extra space before ( in function call [whitespace/parens] [4] Source/WebKit/mac/WebView/WebViewPrivate.h:721: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 8
2011-10-20 16:33:20 PDT
Comment on
attachment 111848
[details]
proposed patch Clearing flags on attachment: 111848 Committed
r98038
: <
http://trac.webkit.org/changeset/98038
>
WebKit Review Bot
Comment 9
2011-10-20 16:33:24 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug