Bug 70532 - [EFL] DRT: Allow choosing which backing store to use.
Summary: [EFL] DRT: Allow choosing which backing store to use.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-20 12:03 PDT by Raphael Kubo da Costa (:rakuco)
Modified: 2011-11-03 12:16 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.50 KB, patch)
2011-10-20 12:05 PDT, Raphael Kubo da Costa (:rakuco) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2011-10-20 12:03:21 PDT 
[EFL] DRT: Allow choosing which backing store to use.
Comment 1 Raphael Kubo da Costa (:rakuco) 2011-10-20 12:05:42 PDT 
Created attachment 111818 [details]
Patch
Comment 2 Antonio Gomes 2011-11-03 11:03:17 PDT 
Comment on attachment 111818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111818&action=review

from IRC:

<tonikitoo> rakuco, what is a singlebackingstore approach? what is the normal approach? more than one backing store?

> Tools/DumpRenderTree/efl/DumpRenderTreeView.cpp:97
> +    static Ewk_View_Smart_Class api = EWK_VIEW_SMART_CLASS_INIT_NAME_VERSION("DRT_View");

'api' as a variable name here sound a bit strange. could you elaborate?
Comment 3 Antonio Gomes 2011-11-03 11:08:18 PDT 
Comment on attachment 111818 [details]
Patch

after talking on IRC, r+, but I am not a fan of the naming used here. feel free to improve it according to your explaination bellow

<rakuco> tonikitoo: the efl port has two backing stores implemented in WebKit/efl/ewk. the single backing store just paints what's on the viewport, whereas the tiled one is similar to what exists in webcore (it predates the webcore implementation afaik). there's no normal approach (one has to choose which one to use in order to use the port), the patch makes it possible to run drt with different backing stores and check if the tests pass in both
Comment 4 WebKit Review Bot 2011-11-03 12:15:58 PDT 
Comment on attachment 111818 [details]
Patch

Clearing flags on attachment: 111818

Committed r99226: <http://trac.webkit.org/changeset/99226>
Comment 5 WebKit Review Bot 2011-11-03 12:16:02 PDT 
All reviewed patches have been landed.  Closing bug.