RESOLVED FIXED70531
Fixed Broken Build on some platforms that require return from non-void methods. 
https://bugs.webkit.org/show_bug.cgi?id=70531
Summary Fixed Broken Build on some platforms that require return from non-void methods.
Fady Samuel
Reported 2011-10-20 11:40:04 PDT
Fixed Broken Build on some platforms that require return from non-void methods.
Attachments
Patch (1.12 KB, patch)
2011-10-20 11:40 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (1.09 KB, patch)
2011-10-20 11:43 PDT, Fady Samuel 		dglazkov: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2011-10-20 11:40:28 PDT
Created attachment 111813 [details] Patch
Fady Samuel
Comment 2 2011-10-20 11:43:15 PDT
Created attachment 111814 [details] Patch
Fady Samuel
Comment 3 2011-10-20 11:43:40 PDT
Removed the no new tests line from the ChangeLog.
epoger
Comment 4 2011-10-20 11:52:38 PDT
Will this patch fix the Chromium "Webkit Mac10.5" builds, such as http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29 ?
Fady Samuel
Comment 5 2011-10-20 12:01:34 PDT
(In reply to comment #4) > Will this patch fix the Chromium "Webkit Mac10.5" builds, such as http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.5%20%28CG%29 ? This looks like a different issue. This fixes Chromium OS builds.
WebKit Review Bot
Comment 6 2011-10-20 12:40:23 PDT
Comment on attachment 111814 [details] Patch Rejecting attachment 111814 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/MediaStreamTrack.cpp Hunk #1 FAILED at 58. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/dom/MediaStreamTrack.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/10180570
Note You need to log in before you can comment on or make changes to this bug.