Bug 70520 - [Qt][WK2] Remove redundant setPageIsVisible() API
Summary: [Qt][WK2] Remove redundant setPageIsVisible() API
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
Depends on:
Reported: 2011-10-20 09:55 PDT by zalan
Modified: 2011-10-25 04:01 PDT (History)
1 user (show)

See Also:

Patch (9.44 KB, patch)
2011-10-20 10:06 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (9.44 KB, patch)
2011-10-20 10:17 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (9.82 KB, patch)
2011-10-24 08:47 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2011-10-20 09:55:46 PDT
[Qt][WK2] Remove redundant setPageIsVisible() API
Comment 1 zalan 2011-10-20 10:06:47 PDT
Created attachment 111798 [details]
Comment 2 WebKit Review Bot 2011-10-20 10:09:10 PDT
Attachment 111798 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 zalan 2011-10-20 10:17:25 PDT
Created attachment 111802 [details]
Comment 4 zalan 2011-10-24 08:47:59 PDT
Created attachment 112192 [details]
Comment 5 Simon Hausmann 2011-10-25 01:39:02 PDT
Comment on attachment 112192 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=112192&action=review


> Source/WebKit2/UIProcess/DrawingAreaProxy.h:-80
> -    virtual void setPageIsVisible(bool isVisible) = 0;

I guess visibilityDidChange() could be made pure virtual now, as suggested in r76157
Comment 6 zalan 2011-10-25 02:01:04 PDT
as discussed on irc.

zalan: simon_: i think when tileddrawingarea gets thrashed would be the good time to review the pure virtual functions. there are a few more that can be cleaned up once the tiled class goes away
zalan: simon_: so that would be like one patch to fix the class design
zalan: simon_: but if you have strong opinion on this, i can do that now. i can go either way
simon_: no, you're right. might make more sense to do it all in one shot
Comment 7 WebKit Review Bot 2011-10-25 04:00:58 PDT
Comment on attachment 112192 [details]

Clearing flags on attachment: 112192

Committed r98332: <http://trac.webkit.org/changeset/98332>
Comment 8 WebKit Review Bot 2011-10-25 04:01:02 PDT
All reviewed patches have been landed.  Closing bug.