RESOLVED FIXED 70500
[GTK] webkitgtk's pkgconfig file needs to require javascriptcoregtk 
https://bugs.webkit.org/show_bug.cgi?id=70500
Summary [GTK] webkitgtk's pkgconfig file needs to require javascriptcoregtk
Gustavo Noronha (kov)
Reported 2011-10-20 07:44:11 PDT
[GTK] webkitgtk's pkgconfig file needs to require javascriptcoregtk
Attachments
Patch (1.29 KB, patch)
2011-10-20 07:45 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2011-10-20 07:45:04 PDT
Created attachment 111771 [details] Patch
Gustavo Noronha (kov)
Comment 2 2011-10-20 07:46:50 PDT
We want to keep API compatibility, so applications that built before continue building. With the release of 1.6.x that's not the case for applications that use JSC, though: $ gcc -o test test.c $(pkg-config --cflags --libs webkitgtk-3.0) /tmp/ccKd7Use.o:gcds.c:function set_can_register_cb: error: undefined reference to 'JSValueMakeNull' /tmp/ccKd7Use.o:gcds.c:function set_can_register_cb: error: undefined reference to 'JSValueGetType' /tmp/ccKd7Use.o:gcds.c:function set_can_register_cb: error: undefined reference to 'JSValueToBoolean' /tmp/ccKd7Use.o:gcds.c:function main: error: undefined reference to 'JSContextGetGlobalObject' /tmp/ccKd7Use.o:gcds.c:function main: error: undefined reference to 'JSStringCreateWithUTF8CString' /tmp/ccKd7Use.o:gcds.c:function main: error: undefined reference to 'JSObjectMakeFunctionWithCallback' /tmp/ccKd7Use.o:gcds.c:function main: error: undefined reference to 'JSObjectSetProperty' /tmp/ccKd7Use.o:gcds.c:function main: error: undefined reference to 'JSStringRelease' collect2: ld returned 1 exit status We need to add javascriptcoregtk-x.0 to the Requires of the webkit{,gtk}-x.0 one.
Philippe Normand
Comment 3 2011-10-20 07:49:24 PDT
Comment on attachment 111771 [details] Patch r=me
Gustavo Noronha (kov)
Comment 4 2011-10-20 07:59:34 PDT
Comment on attachment 111771 [details] Patch Clearing flags on attachment: 111771 Committed r97979: <http://trac.webkit.org/changeset/97979>
Gustavo Noronha (kov)
Comment 5 2011-10-20 07:59:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.