Bug 70495 - When user is panning with the tiled backing store, the page isn't notified about the scroll position change
Summary: When user is panning with the tiled backing store, the page isn't notified ab...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-20 05:34 PDT by Kenneth Rohde Christiansen
Modified: 2011-10-20 09:47 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.44 KB, patch)
2011-10-20 08:00 PDT, Kenneth Rohde Christiansen 		hausmann: review+
hausmann: commit-queue-
Details | Formatted Diff | Diff
Patch (4.42 KB, patch)
2011-10-20 08:39 PDT, Kenneth Rohde Christiansen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2011-10-20 05:34:53 PDT 
SSIA
Comment 1 Kenneth Rohde Christiansen 2011-10-20 08:00:32 PDT 
Created attachment 111772 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-20 08:02:18 PDT 
Attachment 111772 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/page/FrameView.h:168:  The parameter name "visibleContentRect" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Hausmann 2011-10-20 08:21:41 PDT 
Comment on attachment 111772 [details]
Patch

r=me modulo the style warning :)
Comment 4 Kenneth Rohde Christiansen 2011-10-20 08:39:43 PDT 
Created attachment 111780 [details]
Patch
Comment 5 WebKit Review Bot 2011-10-20 09:47:42 PDT 
Comment on attachment 111780 [details]
Patch

Clearing flags on attachment: 111780

Committed r97989: <http://trac.webkit.org/changeset/97989>
Comment 6 WebKit Review Bot 2011-10-20 09:47:47 PDT 
All reviewed patches have been landed.  Closing bug.