Bug 70494 - [Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
Summary: [Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Simon Hausmann
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-10-20 05:29 PDT by Simon Hausmann
Modified: 2011-10-31 11:31 PDT (History)
2 users (show)

See Also:


Attachments
Patch (24.15 KB, patch)
2011-10-25 05:23 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff
Patch (30.50 KB, patch)
2011-10-27 06:10 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff
Patch for landing (32.38 KB, text/plain)
2011-10-28 01:12 PDT, Simon Hausmann
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2011-10-20 05:29:48 PDT
We're using a bunch of the scene graph classes from QtDeclarative for our Qt 5 build. These
classes will be renamed soon. This bug tracks the patch for adapt the WebKit2/Qt5 build.
Comment 1 Simon Hausmann 2011-10-25 05:23:31 PDT
Created attachment 112324 [details]
Patch
Comment 2 Simon Hausmann 2011-10-25 05:24:19 PDT
Comment on attachment 112324 [details]
Patch

Should not be landed with cq, but manually when the bot is updated.
Comment 3 Andreas Kling 2011-10-26 10:05:54 PDT
Comment on attachment 112324 [details]
Patch

LGTM.
Comment 4 Simon Hausmann 2011-10-27 06:10:45 PDT
Created attachment 112670 [details]
Patch
Comment 5 Kenneth Rohde Christiansen 2011-10-27 06:12:50 PDT
Comment on attachment 112670 [details]
Patch

Looks good.
Comment 6 Simon Hausmann 2011-10-28 01:12:17 PDT
Created attachment 112829 [details]
Patch for landing

This is the right patch for landing (with the updatePaintNode hunk removed)
Comment 7 Csaba Osztrogonác 2011-10-28 06:14:00 PDT
Landed in http://trac.webkit.org/changeset/98721 and one more fix landed in http://trac.webkit.org/changeset/98722