RESOLVED FIXED 70469
Document.cpp shouldn't need to know about every event for every feature 
https://bugs.webkit.org/show_bug.cgi?id=70469
Summary Document.cpp shouldn't need to know about every event for every feature
Adam Barth
Reported 2011-10-19 20:12:39 PDT
Document.cpp shouldn't need to know about every event for every feature
Attachments
Patch (28.79 KB, patch)
2011-10-19 20:13 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
The generated file (6.24 KB, text/plain)
2011-10-19 20:14 PDT, Adam Barth 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-10-19 20:13:56 PDT
Created attachment 111714 [details] Patch
Adam Barth
Comment 2 2011-10-19 20:14:47 PDT
Created attachment 111715 [details] The generated file
Eric Seidel (no email)
Comment 3 2011-10-19 20:17:49 PDT
Comment on attachment 111714 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111714&action=review LGTM. > Source/WebCore/WebCore.gyp/scripts/action_makenames.py:120 > + if inputBasename == 'make_names.pl' \ > + or inputBasename == 'make_event_factory.pl': Really? > Source/WebCore/dom/EventFactory.h:38 > + static PassRefPtr<Event> create(const String& eventType); AtomicString?
Adam Barth
Comment 4 2011-10-19 21:02:20 PDT
Yeah, I would have thought atomic string too, but that's not how the old code worked.
Adam Barth
Comment 5 2011-10-19 21:49:12 PDT
Committed r97933: <http://trac.webkit.org/changeset/97933>
Sam Weinig
Comment 6 2011-10-19 22:00:30 PDT
Looks like this probably changed the behavior for the TouchEvent interface when the RuntimeSwitch was off. Was that intentional? Do we care?
Adam Barth
Comment 7 2011-10-19 22:01:47 PDT
Yeah, I decided I didn't care. None of the other features work that way.
Adam Barth
Comment 8 2011-10-19 22:01:55 PDT
I should have noted that in the ChangeLog.
Sam Weinig
Comment 9 2011-10-19 22:04:41 PDT
(In reply to comment #8) > I should have noted that in the ChangeLog. Ok, just making sure.
Note You need to log in before you can comment on or make changes to this bug.