Bug 70455 - [chromium/mac] Add support for building with make
Summary: [chromium/mac] Add support for building with make
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-19 16:53 PDT by Nico Weber
Modified: 2011-10-20 17:15 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.40 KB, patch)
2011-10-19 16:56 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (7.19 KB, patch)
2011-10-20 13:51 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch (7.57 KB, patch)
2011-10-20 13:53 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
Patch for landing (7.57 KB, patch)
2011-10-20 15:35 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2011-10-19 16:53:09 PDT 
[chromium/mac] Add support for building with make
Comment 1 Nico Weber 2011-10-19 16:56:42 PDT 
Created attachment 111696 [details]
Patch
Comment 2 Nico Weber 2011-10-20 13:35:27 PDT 
Comment on attachment 111696 [details]
Patch

needs tweaking
Comment 3 Nico Weber 2011-10-20 13:51:08 PDT 
Created attachment 111841 [details]
Patch
Comment 4 Nico Weber 2011-10-20 13:53:55 PDT 
Created attachment 111843 [details]
Patch
Comment 5 Nico Weber 2011-10-20 13:56:45 PDT 
(Yesterday's clobber build time for chromium/mac was 23 min, today with clang on by default it's 18 min, and with this patch and make it's 12min on my machine)
Comment 6 Adam Barth 2011-10-20 14:08:34 PDT 
Comment on attachment 111843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111843&action=review

This is great.

> Tools/Scripts/webkitdirs.pm:922
> +    if (-e 'Makefile.chromium') {
> +      unless (-e 'Source/WebKit/chromium/WebKit.xcodeproj') {
> +        $hasUpToDateMakefile = 1;
> +      } else {
> +        $hasUpToDateMakefile = stat('Makefile.chromium')->mtime > stat('Source/WebKit/chromium/WebKit.xcodeproj')->mtime;
> +      }
> +    }

four-space indent.
Comment 7 Nico Weber 2011-10-20 15:33:39 PDT 
Comment on attachment 111843 [details]
Patch

argh misclicked
Comment 8 Nico Weber 2011-10-20 15:35:05 PDT 
Created attachment 111857 [details]
Patch for landing
Comment 9 WebKit Review Bot 2011-10-20 17:15:36 PDT 
Comment on attachment 111857 [details]
Patch for landing

Clearing flags on attachment: 111857

Committed r98045: <http://trac.webkit.org/changeset/98045>
Comment 10 WebKit Review Bot 2011-10-20 17:15:42 PDT 
All reviewed patches have been landed.  Closing bug.