Bug 70450 - fix repaint bugs in new flexbox
Summary: fix repaint bugs in new flexbox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-19 16:07 PDT by Tony Chang
Modified: 2011-10-20 15:03 PDT (History)
3 users (show)

See Also:


Attachments
Patch (27.48 KB, patch)
2011-10-19 16:09 PDT, Tony Chang
no flags Details | Formatted Diff | Diff
Patch for landing (62.48 KB, patch)
2011-10-20 11:54 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-10-19 16:07:24 PDT
fix repaint bugs in new flexbox
Comment 1 Tony Chang 2011-10-19 16:09:52 PDT
Created attachment 111691 [details]
Patch
Comment 2 Dave Hyatt 2011-10-20 11:18:22 PDT
Comment on attachment 111691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111691&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:706
> +    if (!selfNeedsLayout() && child->checkForRepaintDuringLayout())
> +        child->repaintDuringLayoutIfMoved(oldRect);

Shouldn't this be done inside setFlowAwareLogicalLocationForChild?
Comment 3 Dave Hyatt 2011-10-20 11:19:06 PDT
Never mind. Disregard.
Comment 4 Dave Hyatt 2011-10-20 11:19:18 PDT
Comment on attachment 111691 [details]
Patch

r=me
Comment 5 Tony Chang 2011-10-20 11:54:02 PDT
Created attachment 111817 [details]
Patch for landing
Comment 6 Tony Chang 2011-10-20 11:54:28 PDT
(In reply to comment #5)
> Created an attachment (id=111817) [details]
> Patch for landing

I added an rtl-column test case on Ojan's suggestion.
Comment 7 WebKit Review Bot 2011-10-20 15:03:13 PDT
Comment on attachment 111817 [details]
Patch for landing

Clearing flags on attachment: 111817

Committed r98024: <http://trac.webkit.org/changeset/98024>
Comment 8 WebKit Review Bot 2011-10-20 15:03:18 PDT
All reviewed patches have been landed.  Closing bug.