Bug 70441 - [chromium] Fix webkit style for a few files
Summary: [chromium] Fix webkit style for a few files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shawn Singh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-19 14:25 PDT by Shawn Singh
Modified: 2011-10-19 19:41 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.78 KB, patch)
2011-10-19 14:28 PDT, Shawn Singh 		no flags Details | Formatted Diff | Diff
included bug URL to changelog and removed unnecessary include file (4.70 KB, patch)
2011-10-19 16:14 PDT, Shawn Singh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Singh 2011-10-19 14:25:17 PDT 
Just a 30-second fix to remove some errors when running the check-webkit-style script.
Comment 1 Shawn Singh 2011-10-19 14:28:59 PDT 
Created attachment 111675 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-19 15:33:28 PDT 
Attachment 111675 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 James Robinson 2011-10-19 15:49:31 PDT 
Comment on attachment 111675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111675&action=review

Thanks for fixing these. The stylebot is correct, though, that the ChangeLog entry needs a bug number.  Will R+ soon as that's addressed.

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:42
> +#include "GraphicsContext3D.h"

I guess this wasn't sorted correctly?

Now that you're moving it, though, do we need it at all in LayerChromium.cpp? I think the answer is that we don't now that drawTexturedQuad is no longer in LayerChromium. Can you try deleting it?
Comment 4 Shawn Singh 2011-10-19 16:14:29 PDT 
Created attachment 111692 [details]
included bug URL to changelog and removed unnecessary include file
Comment 5 James Robinson 2011-10-19 16:22:25 PDT 
Comment on attachment 111692 [details]
included bug URL to changelog and removed unnecessary include file

Cool! thanks.
Comment 6 WebKit Review Bot 2011-10-19 19:41:52 PDT 
Comment on attachment 111692 [details]
included bug URL to changelog and removed unnecessary include file

Clearing flags on attachment: 111692

Committed r97924: <http://trac.webkit.org/changeset/97924>
Comment 7 WebKit Review Bot 2011-10-19 19:41:56 PDT 
All reviewed patches have been landed.  Closing bug.