Bug 70441 – [chromium] Fix webkit style for a few files

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Shawn Singh]

Just a 30-second fix to remove some errors when running the check-webkit-style script.

[Shawn Singh]

Created attachment 111675 [details]
Patch

[WebKit Review Bot]

Attachment 111675 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[James Robinson]

Comment on attachment 111675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111675&action=review

Thanks for fixing these. The stylebot is correct, though, that the ChangeLog entry needs a bug number.  Will R+ soon as that's addressed.

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:42
> +#include "GraphicsContext3D.h"

I guess this wasn't sorted correctly?

Now that you're moving it, though, do we need it at all in LayerChromium.cpp? I think the answer is that we don't now that drawTexturedQuad is no longer in LayerChromium. Can you try deleting it?

[Shawn Singh]

Created attachment 111692 [details]
included bug URL to changelog and removed unnecessary include file

[James Robinson]

Comment on attachment 111692 [details]
included bug URL to changelog and removed unnecessary include file

Cool! thanks.

[WebKit Review Bot]

Comment on attachment 111692 [details]
included bug URL to changelog and removed unnecessary include file

Clearing flags on attachment: 111692

Committed r97924: <http://trac.webkit.org/changeset/97924>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.