Bug 70416 - NRWT doesn't support ORWT's --root option, but should
Summary: NRWT doesn't support ORWT's --root option, but should
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords: InRadar
Depends on:
Blocks: 34984
  Show dependency tree / graph
 
Reported: 2011-10-19 07:13 PDT by Adam Roben (:aroben)
Modified: 2011-10-24 13:53 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.43 KB, patch)
2011-10-24 11:31 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-10-19 07:13:33 PDT 
ORWT supports a --root flag that tells it where to find the built copy of WebKit. NRWT should support this option, too.
Comment 1 Radar WebKit Bug Importer 2011-10-19 07:14:08 PDT 
<rdar://problem/10310764>
Comment 2 Eric Seidel (no email) 2011-10-24 11:31:04 PDT 
Created attachment 112217 [details]
Patch
Comment 3 Eric Seidel (no email) 2011-10-24 11:31:26 PDT 
Please let me know if this behaves as you would expect it should.
Comment 4 Adam Roben (:aroben) 2011-10-24 11:38:49 PDT 
Comment on attachment 112217 [details]
Patch

The behavior of the test looks right to me. I'll let an NRWT aficionado r+ the patch.
Comment 5 WebKit Review Bot 2011-10-24 13:53:22 PDT 
Comment on attachment 112217 [details]
Patch

Clearing flags on attachment: 112217

Committed r98279: <http://trac.webkit.org/changeset/98279>
Comment 6 WebKit Review Bot 2011-10-24 13:53:27 PDT 
All reviewed patches have been landed.  Closing bug.