Bug 70410 – Strip trailing whitespace in the WebCore/css C++ code

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Alexander Pavlov (apavlov)]

Patch to follow.

[Alexander Pavlov (apavlov)]

Created attachment 111594 [details]
[PATCH] Suggested fix

[WebKit Review Bot]

Attachment 111594 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/css/CSSStyleSelector.cpp:1625:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/CSSStyleSelector.cpp:2573:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/CSSStyleSelector.cpp:2580:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/CSSParser.cpp:5688:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/CSSParser.cpp:5715:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/MediaQueryExp.h:60:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 7 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexander Pavlov (apavlov)]

Created attachment 111598 [details]
[PATCH] Multiline boolean expressions fixed where necessary to avoid style violations.

[WebKit Review Bot]

Attachment 111598 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexander Pavlov (apavlov)]

Created attachment 111599 [details]
[PATCH] Tab removed

[Dirk Schulze]

Comment on attachment 111599 [details]
[PATCH] Tab removed

rs=me.

[Alexander Pavlov (apavlov)]

Committed r97854: <http://trac.webkit.org/changeset/97854>

[Eric Seidel (no email)]

I'm surprised that such a far-reaching change was not announced (or discussed) on webkit-dev first. :(

[Luke Macpherson]

Way to break all my outstanding patches. Thanks guys.

[Eric Seidel (no email)]

I would encourage you to use webkit-patch apply-attachment --non-interactive, or simply roll back to a revision before this change, apply your patch, and then let git rebase do the right thing.