Bug 70410 - Strip trailing whitespace in the WebCore/css C++ code
Summary: Strip trailing whitespace in the WebCore/css C++ code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-19 05:12 PDT by Alexander Pavlov (apavlov)
Modified: 2011-10-19 16:47 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Suggested fix (228.11 KB, patch)
2011-10-19 05:13 PDT, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
[PATCH] Multiline boolean expressions fixed where necessary to avoid style violations. (231.32 KB, patch)
2011-10-19 05:22 PDT, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
[PATCH] Tab removed (231.32 KB, patch)
2011-10-19 05:26 PDT, Alexander Pavlov (apavlov) 		krit: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-10-19 05:12:26 PDT 
Patch to follow.
Comment 1 Alexander Pavlov (apavlov) 2011-10-19 05:13:59 PDT 
Created attachment 111594 [details]
[PATCH] Suggested fix
Comment 2 WebKit Review Bot 2011-10-19 05:17:35 PDT 
Attachment 111594 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/css/CSSStyleSelector.cpp:1625:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/CSSStyleSelector.cpp:2573:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/CSSStyleSelector.cpp:2580:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/CSSParser.cpp:5688:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/CSSParser.cpp:5715:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/css/MediaQueryExp.h:60:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 7 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexander Pavlov (apavlov) 2011-10-19 05:22:24 PDT 
Created attachment 111598 [details]
[PATCH] Multiline boolean expressions fixed where necessary to avoid style violations.
Comment 4 WebKit Review Bot 2011-10-19 05:25:56 PDT 
Attachment 111598 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 90 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alexander Pavlov (apavlov) 2011-10-19 05:26:19 PDT 
Created attachment 111599 [details]
[PATCH] Tab removed
Comment 6 Dirk Schulze 2011-10-19 06:20:05 PDT 
Comment on attachment 111599 [details]
[PATCH] Tab removed

rs=me.
Comment 7 Alexander Pavlov (apavlov) 2011-10-19 06:30:40 PDT 
Committed r97854: <http://trac.webkit.org/changeset/97854>
Comment 8 Eric Seidel (no email) 2011-10-19 16:37:43 PDT 
I'm surprised that such a far-reaching change was not announced (or discussed) on webkit-dev first. :(
Comment 9 Luke Macpherson 2011-10-19 16:42:33 PDT 
Way to break all my outstanding patches. Thanks guys.
Comment 10 Eric Seidel (no email) 2011-10-19 16:47:32 PDT 
I would encourage you to use webkit-patch apply-attachment --non-interactive, or simply roll back to a revision before this change, apply your patch, and then let git rebase do the right thing.