WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70394
Date.prototype.toISOString fails to throw exception
https://bugs.webkit.org/show_bug.cgi?id=70394
Summary
Date.prototype.toISOString fails to throw exception
Gavin Barraclough
Reported
2011-10-18 18:34:45 PDT
Should throw a range error if the internal value is not finite.
Attachments
Fix
(3.85 KB, patch)
2011-10-18 18:37 PDT
,
Gavin Barraclough
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2011-10-18 18:37:57 PDT
Created
attachment 111549
[details]
Fix
Sam Weinig
Comment 2
2011-10-18 18:42:32 PDT
Comment on
attachment 111549
[details]
Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=111549&action=review
> Source/JavaScriptCore/runtime/DatePrototype.cpp:510 > + if (!isfinite(thisDateObj->internalNumber())) > + return throwVMError(exec, createRangeError(exec, "Invalid Date")); > + > +
WHITESPACE!! ! !!!! !!!
Gavin Barraclough
Comment 3
2011-10-18 18:49:19 PDT
Fixed in
r97826
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug