RESOLVED INVALID Bug 70371
DRT should always print a newline after #EOF 
https://bugs.webkit.org/show_bug.cgi?id=70371
Summary DRT should always print a newline after #EOF
Eric Seidel (no email)
Reported 2011-10-18 15:02:40 PDT
DRT should always print a newline after #EOF
Attachments
Patch (6.48 KB, patch)
2011-10-18 15:06 PDT, Eric Seidel (no email) 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-10-18 15:06:24 PDT
Created attachment 111509 [details] Patch
Eric Seidel (no email)
Comment 2 2011-10-18 15:13:14 PDT
Important to let this land through the commit-queue to make sure I didn't screw anything up in my testing.
Dirk Pranke
Comment 3 2011-10-18 15:18:49 PDT
this change looks fine. Note that we don't enforce that the #EOF start at the beginning of the line either (specifically, in the case of audio tests where the main output is binary data, not text). Does it make sense to change that as well?
Eric Seidel (no email)
Comment 4 2011-10-18 15:30:15 PDT
The code seems mixed about whether #EOF is on its own line or not. Since adding a \n before #EOF might add a \n to some test results, I decided to avoid it for now. You're right that it's possible we're silently ignoring some content in ORWT due to lack of requiring #EOF to be on a line by itself.
Eric Seidel (no email)
Comment 5 2011-10-18 15:32:00 PDT
Comment on attachment 111509 [details] Patch re-testing ORWT, I'm seeing failure. Checking...
Eric Seidel (no email)
Comment 6 2011-10-19 12:13:20 PDT
This is invalid. I was just confused. puts always prints a newline after the string. This change caused us to print double-newlines. The opposite change is probably correct to remove the \n from all the places where we currently have "#EOF\n".
Note You need to log in before you can comment on or make changes to this bug.