Bug 70368 - [Qt] MiniBrowser seems to be busted on qt5
Summary: [Qt] MiniBrowser seems to be busted on qt5
Status: RESOLVED DUPLICATE of bug 70315
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-18 14:47 PDT by Gopal Raghavan
Modified: 2011-10-20 11:55 PDT (History)
5 users (show)

See Also:

Attachments
qmlminibrowser patch (11.13 KB, patch)
2011-10-18 15:05 PDT, Gopal Raghavan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gopal Raghavan 2011-10-18 14:47:43 PDT 
Probably due to all the dependencies with qwidget in qt5.
I propose that we have a super simple qml based minibrowser.
Comment 1 Gopal Raghavan 2011-10-18 15:05:07 PDT 
Created attachment 111508 [details]
qmlminibrowser patch 

This is a MiniBrowser implementation based on qml. The browser has three regions: toggle, url and webview. Toggle allows us to switch between TouchWebView and DesktopWebView. If you click on 'D' it will go to DesktopWebView, if you click on 'T' it will go to TouchWebView. In the url area you can enter a specific url.The webview area itself renders the content.
Comment 2 Simon Hausmann 2011-10-19 04:23:14 PDT 
Zeno is working on this in bug #70315
Comment 3 Alexis Menard (darktears) 2011-10-19 05:32:18 PDT 
Comment on attachment 111508 [details]
qmlminibrowser patch 

View in context: https://bugs.webkit.org/attachment.cgi?id=111508&action=review

I don't think it should be in addition of MiniBrowser, it should replace it.

I think also the view switching is not very nice the way it is implemented.

I think it's work in progress rather than a working thing. I can't land as it is for sure.

Also please sync with zeno to figure out what is the plan.

> Tools/QMLMiniBrowser/qt/browser.qml:48
> +    color: "transparent"

You can just put an Item then.
Comment 4 Zeno Albisser 2011-10-19 06:21:20 PDT 
Jocelyn and me are currently working on a complete replacement for MiniBrowser based on Qt5 and QML.
Comment 5 Zeno Albisser 2011-10-20 10:05:23 PDT 

*** This bug has been marked as a duplicate of bug 70315 ***
Comment 6 Chang Shu 2011-10-20 11:55:21 PDT 
Comment on attachment 111508 [details]
qmlminibrowser patch 

clear flags on the patch since the bug itself is set as resolved.