Bug 70346 - Rename some "Cue" classes to "TextTrack"
Summary: Rename some "Cue" classes to "TextTrack"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-10-18 11:58 PDT by Eric Carlson
Modified: 2011-10-20 11:05 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (81.35 KB, patch)
2011-10-18 13:45 PDT, Eric Carlson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-10-18 11:58:54 PDT
As suggested in bug 70269, rename CueLoader -> TextTrackLoader and CachedCues -> CachedTextTrack.
Comment 1 Radar WebKit Bug Importer 2011-10-18 11:59:37 PDT
<rdar://problem/10305321>
Comment 2 Eric Carlson 2011-10-18 13:45:02 PDT
Created attachment 111496 [details]
Proposed patch
Comment 3 Darin Adler 2011-10-18 14:03:53 PDT
Comment on attachment 111496 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111496&action=review

> Source/WebCore/GNUmakefile.list.am:1643
>  	Source/WebCore/html/ColorInputType.h \
> -	Source/WebCore/html/CueIndex.cpp \
> -	Source/WebCore/html/CueIndex.h \
> +	Source/WebCore/html/TextTrackCueIndex.cpp \
> +	Source/WebCore/html/TextTrackCueIndex.h \
>  	Source/WebCore/html/DateInputType.cpp \

Probably better to keep these sorted alphabetically.

> Source/WebCore/WebCore.gypi:2771
>              'loader/CrossOriginPreflightResultCache.cpp',
> -            'loader/CueLoader.cpp',
> -            'loader/CueLoader.h',
> +            'loader/TextTrackLoader.cpp',
> +            'loader/TextTrackLoader.h',
>              'loader/DocumentLoader.cpp',

Probably better to keep these sorted alphabetically.

> Source/WebCore/WebCore.gypi:5363
>              'html/ColorInputType.h',
> -            'html/CueIndex.cpp',
> -            'html/CueIndex.h',
> +            'html/TextTrackCueIndex.cpp',
> +            'html/TextTrackCueIndex.h',
>              'html/DOMFormData.cpp',

Probably better to keep these sorted alphabetically.
Comment 4 Alexis Menard (darktears) 2011-10-18 16:26:19 PDT
Comment on attachment 111496 [details]
Proposed patch

And Qt? It's missing the change in the WebCore.pro.
Comment 5 Eric Carlson 2011-10-19 13:29:43 PDT
(In reply to comment #4)
> (From update of attachment 111496 [details])
> And Qt? It's missing the change in the WebCore.pro.

My mistake - I assumed the project file didn't have any of these files because the feature isn't enabled but I see that it does have some of the .h files for some reason. I will fix it before landing.
Comment 6 Eric Carlson 2011-10-20 11:05:26 PDT
http://trac.webkit.org/changeset/98000