WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70345
Add WebKit API to hide the definition window
https://bugs.webkit.org/show_bug.cgi?id=70345
Summary
Add WebKit API to hide the definition window
Damian Kaleta
Reported
2011-10-18 11:47:41 PDT
Add WebKit API to hide the definition window.
Attachments
patch
(1.72 KB, patch)
2011-10-18 12:18 PDT
,
Damian Kaleta
no flags
Details
Formatted Diff
Diff
patch that doesn't break SL build
(1.79 KB, patch)
2011-10-18 15:55 PDT
,
Damian Kaleta
sam
: review-
Details
Formatted Diff
Diff
yet another patch
(1.77 KB, patch)
2011-10-18 16:03 PDT
,
Damian Kaleta
sam
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Damian Kaleta
Comment 1
2011-10-18 12:18:06 PDT
Created
attachment 111478
[details]
patch
Kevin Decker
Comment 2
2011-10-18 13:50:14 PDT
Committed revision 97788.
Damian Kaleta
Comment 3
2011-10-18 15:54:53 PDT
Need to fix SL build.
Damian Kaleta
Comment 4
2011-10-18 15:55:57 PDT
Created
attachment 111515
[details]
patch that doesn't break SL build
Darin Adler
Comment 5
2011-10-18 15:57:16 PDT
Comment on
attachment 111515
[details]
patch that doesn't break SL build I might put the #ifndef inside the method and make it harmless but pointless to call it on SnowLeopard, but this is OK.
Sam Weinig
Comment 6
2011-10-18 15:58:56 PDT
Comment on
attachment 111515
[details]
patch that doesn't break SL build View in context:
https://bugs.webkit.org/attachment.cgi?id=111515&action=review
> Source/WebKit2/UIProcess/API/mac/WKViewPrivate.h:38 > +#if !defined(BUILDING_ON_SNOW_LEOPARD)
I don't think you can do #if !defined(BUILDING_ON_SNOW_LEOPARD) in a header. Reversing drain's r+. You can just put the #if !defined(BUILDING_ON_SNOW_LEOPARD) in the implementation.
Darin Adler
Comment 7
2011-10-18 15:59:19 PDT
Going down the reversing drain!
Damian Kaleta
Comment 8
2011-10-18 16:03:36 PDT
Created
attachment 111517
[details]
yet another patch
Sam Weinig
Comment 9
2011-10-18 16:04:21 PDT
Comment on
attachment 111517
[details]
yet another patch Better, I will test and land.
Sam Weinig
Comment 10
2011-10-18 16:08:19 PDT
Landed in 97806.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug