Bug 70342 - Support percentage value for CSS property "-webkit-text-size-adjust"
Summary: Support percentage value for CSS property "-webkit-text-size-adjust"
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Chang Shu
Depends on: 56543
  Show dependency treegraph
Reported: 2011-10-18 11:03 PDT by Chang Shu
Modified: 2012-04-04 23:02 PDT (History)
15 users (show)

See Also:

Proposed Patch (7.29 KB, patch)
2012-02-08 02:21 PST, Parag Radke
cshu: review-
cshu: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-10-18 11:03:55 PDT
WebKit trunk supports "auto" and "none"  as values for CSS property "-webkit-text-size-adjust". We should extend this to support percentage as it's supported on iOS and it's valuable to all user agents.
Comment 2 Simon Fraser (smfr) 2011-10-18 11:31:26 PDT
See also bug 56543.
Comment 4 Parag Radke 2012-02-08 02:21:11 PST
Created attachment 126034 [details]
Proposed Patch

Patch to support percentage value for CSS property -webkit-text-size-adjust
Comment 5 Simon Fraser (smfr) 2012-02-08 02:29:20 PST
How can you fix this before bug 56543 is resolved?
Comment 6 Alexis Menard (darktears) 2012-02-08 03:47:58 PST
Comment on attachment 126034 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126034&action=review

> Source/WebCore/css/CSSParser.cpp:1993
> +                addProperty(CSSPropertyFontSize, createPrimitiveNumericValue(value), true);

Regardless what simon said, I don't see why you enforced the important parameter of addProperty.
Comment 7 Chang Shu 2012-02-13 01:48:35 PST
Comment on attachment 126034 [details]
Proposed Patch

Thanks for the patch. But I guess we want to hold off the implementation based on the comments from Simon.