Bug 70342 – Support percentage value for CSS property "-webkit-text-size-adjust"

• Status: RESOLVED
• Resolution: LATER
• Component: CSS

[Chang Shu]

WebKit trunk supports "auto" and "none"  as values for CSS property "-webkit-text-size-adjust". We should extend this to support percentage as it's supported on iOS and it's valuable to all user agents.

[Chang Shu]

Some references copied from bug 56543.

=== Reference: ===
Apple Safari Developer Library:

<http://developer.apple.com/library/safari/documentation/appleapplications/reference/safariwebcontent/AdjustingtheTextSize/AdjustingtheTextSize.html#//apple_ref/doc/uid/TP40006510-SW16>

<http://developer.apple.com/library/safari/documentation/appleapplications/reference/SafariCSSRef/Articles/StandardCSSProperties.html#//apple_ref/doc/uid/TP30001266--webkit-text-size-adjust>

<http://css-infos.net/property/-webkit-text-size-adjust>

<http://www.campaignmonitor.com/blog/post/3339/save-your-layout-by-overriding-the-minimum-font-size-on-the-iphone-and/>

[Simon Fraser (smfr)]

See also bug 56543.

[Kenneth Rohde Christiansen]

You might want to have a look at these patches:

https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/d125b56f1b58cbf83b2e89ae129aed822e2f0961
https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/6e33150d62388afbf1389f01e052189ed36859e0
https://gitorious.org/+qtwebkit-webkit2-dev/webkit/qtwebkit-webkit2-dev/commit/74c0cc4c37a53bfade40aad40e422652902361b1

[Parag Radke]

Created attachment 126034 [details]
Proposed Patch

Patch to support percentage value for CSS property -webkit-text-size-adjust

[Simon Fraser (smfr)]

How can you fix this before bug 56543 is resolved?

[Alexis Menard (darktears)]

Comment on attachment 126034 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=126034&action=review

> Source/WebCore/css/CSSParser.cpp:1993
> +                addProperty(CSSPropertyFontSize, createPrimitiveNumericValue(value), true);

Regardless what simon said, I don't see why you enforced the important parameter of addProperty.

[Chang Shu]

Comment on attachment 126034 [details]
Proposed Patch

Thanks for the patch. But I guess we want to hold off the implementation based on the comments from Simon.