Bug 70342 - Support percentage value for CSS property "-webkit-text-size-adjust"
: Support percentage value for CSS property "-webkit-text-size-adjust"
Status: RESOLVED LATER
: WebKit
CSS
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
: 56543
:
  Show dependency treegraph
 
Reported: 2011-10-18 11:03 PST by
Modified: 2012-04-04 23:02 PST (History)


Attachments
Proposed Patch (7.29 KB, patch)
2012-02-08 02:21 PST, Parag Radke
cshu: review-
cshu: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-10-18 11:03:55 PST
WebKit trunk supports "auto" and "none"  as values for CSS property "-webkit-text-size-adjust". We should extend this to support percentage as it's supported on iOS and it's valuable to all user agents.
------- Comment #2 From 2011-10-18 11:31:26 PST -------
See also bug 56543.
------- Comment #4 From 2012-02-08 02:21:11 PST -------
Created an attachment (id=126034) [details]
Proposed Patch

Patch to support percentage value for CSS property -webkit-text-size-adjust
------- Comment #5 From 2012-02-08 02:29:20 PST -------
How can you fix this before bug 56543 is resolved?
------- Comment #6 From 2012-02-08 03:47:58 PST -------
(From update of attachment 126034 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=126034&action=review

> Source/WebCore/css/CSSParser.cpp:1993
> +                addProperty(CSSPropertyFontSize, createPrimitiveNumericValue(value), true);

Regardless what simon said, I don't see why you enforced the important parameter of addProperty.
------- Comment #7 From 2012-02-13 01:48:35 PST -------
(From update of attachment 126034 [details])
Thanks for the patch. But I guess we want to hold off the implementation based on the comments from Simon.