RESOLVED FIXED 70340
Crash in WebProcess at com.apple.AppKit: -[NSFilePromiseDragSource draggedImage:endedAt:operation:] + 101 
https://bugs.webkit.org/show_bug.cgi?id=70340
Summary Crash in WebProcess at com.apple.AppKit: -[NSFilePromiseDragSource draggedIma...
Enrica Casucci
Reported 2011-10-18 10:41:57 PDT
AppKit is not retaining the dragging source. This seems to lead to crashes under some unknown circumstances.
Attachments
patch (2.36 KB, patch)
2011-10-18 10:51 PDT, Enrica Casucci 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2011-10-18 10:51:43 PDT
Created attachment 111468 [details] patch
Darin Adler
Comment 2 2011-10-18 11:36:16 PDT
Comment on attachment 111468 [details] patch OK, lets give this a try.
mitz
Comment 3 2011-10-18 11:50:37 PDT
Comment on attachment 111468 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=111468&action=review > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:61 > @interface NSFilePromiseDragSource : NSObject > { > + id _dragSource; Must we use this extra knowledge about NSFilePromise’s ivar layout (and assign to this ivar)? Couldn’t we have added this as an ivar to WKPasteboardFilePromiseOwner? Perhaps this doesn’t matter in the Objective-C runtime used for WebKit2?
Darin Adler
Comment 4 2011-10-18 12:03:16 PDT
(In reply to comment #3) > Must we use this extra knowledge about NSFilePromise’s ivar layout (and assign to this ivar)? No, we don’t have to. > Couldn’t we have added this as an ivar to WKPasteboardFilePromiseOwner? Yes, we could have done that instead. Enrica and I discussed that option. > Perhaps this doesn’t matter in the Objective-C runtime used for WebKit2? That doesn’t sound right to me. I’m not even sure how that would work.
Enrica Casucci
Comment 5 2011-10-18 16:18:02 PDT
Committed revision 97808.
Note You need to log in before you can comment on or make changes to this bug.