Bug 70340 - Crash in WebProcess at com.apple.AppKit: -[NSFilePromiseDragSource draggedImage:endedAt:operation:] + 101
Summary: Crash in WebProcess at com.apple.AppKit: -[NSFilePromiseDragSource draggedIma...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.7
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-10-18 10:41 PDT by Enrica Casucci
Modified: 2011-10-18 16:18 PDT (History)
2 users (show)

See Also:


Attachments
patch (2.36 KB, patch)
2011-10-18 10:51 PDT, Enrica Casucci
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2011-10-18 10:41:57 PDT
AppKit is not retaining the dragging source. This seems to lead to crashes under some unknown circumstances.
Comment 1 Enrica Casucci 2011-10-18 10:51:43 PDT
Created attachment 111468 [details]
patch
Comment 2 Darin Adler 2011-10-18 11:36:16 PDT
Comment on attachment 111468 [details]
patch

OK, lets give this a try.
Comment 3 mitz 2011-10-18 11:50:37 PDT
Comment on attachment 111468 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111468&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:61
>  @interface NSFilePromiseDragSource : NSObject
>  {
> +    id _dragSource;

Must we use this extra knowledge about NSFilePromise’s ivar layout (and assign to this ivar)? Couldn’t we have added this as an ivar to WKPasteboardFilePromiseOwner? Perhaps this doesn’t matter in the Objective-C runtime used for WebKit2?
Comment 4 Darin Adler 2011-10-18 12:03:16 PDT
(In reply to comment #3)
> Must we use this extra knowledge about NSFilePromise’s ivar layout (and assign to this ivar)?

No, we don’t have to.

> Couldn’t we have added this as an ivar to WKPasteboardFilePromiseOwner?

Yes, we could have done that instead. Enrica and I discussed that option.

> Perhaps this doesn’t matter in the Objective-C runtime used for WebKit2?

That doesn’t sound right to me. I’m not even sure how that would work.
Comment 5 Enrica Casucci 2011-10-18 16:18:02 PDT
Committed revision 97808.