Bug 70335 - Web Inspector: Enable caseSensitive search / Regex support in advanced search.
Summary: Web Inspector: Enable caseSensitive search / Regex support in advanced search.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-18 10:14 PDT by Vsevolod Vlasov
Modified: 2011-10-19 05:36 PDT (History)
11 users (show)

See Also:

Attachments
Patch (36.67 KB, patch)
2011-10-18 10:21 PDT, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (40.66 KB, patch)
2011-10-18 10:41 PDT, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2011-10-18 10:14:43 PDT 
Enable caseSensitive search / Regex support in advanced search.
Comment 1 Vsevolod Vlasov 2011-10-18 10:21:11 PDT 
Created attachment 111462 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-18 10:23:34 PDT 
Attachment 111462 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1

Source/WebCore/inspector/InspectorDebuggerAgent.cpp:324:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorPageAgent.cpp:487:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorPageAgent.h:100:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.h:84:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 4 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Vsevolod Vlasov 2011-10-18 10:41:24 PDT 
Created attachment 111466 [details]
Patch
Comment 4 WebKit Review Bot 2011-10-18 10:44:37 PDT 
Attachment 111466 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/http..." exit_code: 1

Source/WebCore/inspector/InspectorPageAgent.h:100:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.cpp:324:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorPageAgent.cpp:487:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorDebuggerAgent.h:84:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 4 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Pavel Feldman 2011-10-19 02:59:53 PDT 
Comment on attachment 111466 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111466&action=review

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:328
> +        *results = ContentSearchUtils::searchInTextByLines(it->second.source, query, *caseSensitive, *isRegex);

What boolean value is written in the address 0?
Comment 6 Vsevolod Vlasov 2011-10-19 05:36:51 PDT 
Committed r97851: <http://trac.webkit.org/changeset/97851>