Bug 70334 - Web Inspector: make extension tests pass on chromium
Summary: Web Inspector: make extension tests pass on chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords: PlatformOnly
Depends on: 70624
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-18 10:14 PDT by Andrey Kosyakov
Modified: 2011-10-21 11:09 PDT (History)
12 users (show)

See Also:

Attachments
patch (12.63 KB, patch)
2011-10-18 10:17 PDT, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-10-18 10:14:05 PDT 
We need a handful of custom expectations plus somewhat better serialization to avoid flakiness exposed by chromium DRT MessagePort implementation.
Comment 1 Andrey Kosyakov 2011-10-18 10:17:31 PDT 
Created attachment 111461 [details]
patch
Comment 2 Andrey Kosyakov 2011-10-19 05:21:59 PDT 
Comment on attachment 111461 [details]
patch

Clearing flags on attachment: 111461

Committed r97850: <http://trac.webkit.org/changeset/97850>
Comment 3 Andrey Kosyakov 2011-10-19 05:22:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Balazs Kelemen 2011-10-19 06:43:17 PDT 
Seems like inspector/extensions/extensions-events.html and inspector/extensions/extensions-network.html times out on our Qt-Mac bot after this change: http://build.webkit.sed.hu/results/Qt%20SnowLeopard%20Intel%20Release/r97851%20(7122)/results.html

Do you have an idea why can that happen?
Comment 5 Andrey Kosyakov 2011-10-19 07:07:44 PDT 
(In reply to comment #4)
> Seems like inspector/extensions/extensions-events.html and inspector/extensions/extensions-network.html times out on our Qt-Mac bot after this change: http://build.webkit.sed.hu/results/Qt%20SnowLeopard%20Intel%20Release/r97851%20(7122)/results.html
> 
> Do you have an idea why can that happen?

No idea yet, but I'll have a look (though it'll take me some time to setup the environment). I'll disable these tests on qt-mac for the time being.
Comment 6 Julien Chaffraix 2011-10-21 11:09:23 PDT 
(In reply to comment #5)
> (In reply to comment #4)
> > Seems like inspector/extensions/extensions-events.html and inspector/extensions/extensions-network.html times out on our Qt-Mac bot after this change: http://build.webkit.sed.hu/results/Qt%20SnowLeopard%20Intel%20Release/r97851%20(7122)/results.html
> > 
> > Do you have an idea why can that happen?
> 
> No idea yet, but I'll have a look (though it'll take me some time to setup the environment). I'll disable these tests on qt-mac for the time being.

Some of the enabled tests were failing in the integration build on Windows Dbg:

http/tests/inspector/extensions-headers.html = TIMEOUT
http/tests/inspector/extensions-network-redirect.html = TIMEOUT
http/tests/inspector/extensions-useragent.html = TIMEOUT

I am reverting the change to keep them green.