WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70326
XSLStyleSheet only needs to manage XSLImportRule children.
https://bugs.webkit.org/show_bug.cgi?id=70326
Summary
XSLStyleSheet only needs to manage XSLImportRule children.
Andreas Kling
Reported
2011-10-18 06:43:29 PDT
The only StyleBase subclass that ever goes into XSLStyleSheet::m_children is XSLImportRule, so let's be specific about that.
Attachments
Proposed patch
(9.25 KB, patch)
2011-10-18 07:02 PDT
,
Andreas Kling
koivisto
: review+
koivisto
: commit-queue-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2011-10-18 07:02:34 PDT
Created
attachment 111438
[details]
Proposed patch
Antti Koivisto
Comment 2
2011-10-18 07:13:49 PDT
Comment on
attachment 111438
[details]
Proposed patch View in context:
https://bugs.webkit.org/attachment.cgi?id=111438&action=review
glorious, r=me
> Source/WebCore/xml/XSLStyleSheetLibxslt.cpp:297 > + return child->document(); > } > + } else { > + xmlDocPtr result = import->styleSheet()->locateStylesheetSubResource(parentDoc, uri); > + if (result) > + return result; > }
I would use continue at the end of if() and remove the else.
Early Warning System Bot
Comment 3
2011-10-18 07:23:52 PDT
Comment on
attachment 111438
[details]
Proposed patch
Attachment 111438
[details]
did not pass qt-ews (qt): Output:
http://queues.webkit.org/results/10120264
Andreas Kling
Comment 4
2011-10-18 07:34:13 PDT
Committed
r97751
: <
http://trac.webkit.org/changeset/97751
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug