Bug 70319 - [GTK] Enable to use built-product-archive on GTK platform
Summary: [GTK] Enable to use built-product-archive on GTK platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gabor Rapcsanyi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-18 05:52 PDT by Gabor Rapcsanyi
Modified: 2011-10-19 07:06 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (2.59 KB, patch)
2011-10-19 06:02 PDT, Gabor Rapcsanyi 		ossy: review+
ossy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Rapcsanyi 2011-10-18 05:52:49 PDT 
Implement the GTK platform in built-product-archive script.
Comment 1 Gabor Rapcsanyi 2011-10-19 06:02:37 PDT 
Created attachment 111602 [details]
proposed patch
Comment 2 Csaba Osztrogonác 2011-10-19 06:05:51 PDT 
Comment on attachment 111602 [details]
proposed patch

LGTM, r=me. Please land it manually, because commmit queue still hates my name. :-S
Comment 3 Philippe Normand 2011-10-19 06:15:17 PDT 
Comment on attachment 111602 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111602&action=review

> Tools/BuildSlaveSupport/built-product-archive:95
> +            neededDirectories = ["Programs", ".lib"]

it's .libs
Comment 4 Gabor Rapcsanyi 2011-10-19 06:29:15 PDT 
(In reply to comment #3)
> (From update of attachment 111602 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111602&action=review
> 
> > Tools/BuildSlaveSupport/built-product-archive:95
> > +            neededDirectories = ["Programs", ".lib"]
> 
> it's .libs

Sure, I will fix that thanks.
Comment 5 Gabor Rapcsanyi 2011-10-19 07:06:11 PDT 
Landed in http://trac.webkit.org/changeset/97856