WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70313
[Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
https://bugs.webkit.org/show_bug.cgi?id=70313
Summary
[Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
Ryosuke Niwa
Reported
2011-10-18 01:12:58 PDT
Chromium Mac bots need to run tests with fully-qualified --chromium-cg-mac instead of just --platform in order to use correct expectations. But we're currently running nrwt with --chromium.
Attachments
fixes the bug
(2.09 KB, patch)
2011-10-18 02:11 PDT
,
Ryosuke Niwa
no flags
Details
Formatted Diff
Diff
fixed typo
(2.09 KB, patch)
2011-10-18 09:35 PDT
,
Ryosuke Niwa
abarth
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2011-10-18 02:11:36 PDT
Created
attachment 111411
[details]
fixes the bug
Adam Barth
Comment 2
2011-10-18 08:38:13 PDT
Comment on
attachment 111411
[details]
fixes the bug View in context:
https://bugs.webkit.org/attachment.cgi?id=111411&action=review
Why don't we always pass the full platform?
> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:91 > +def appendCustomBuildFlags(step, platform, fullPlatform="", useFullPlatformCorChromiumCGMac=False):
useFullPlatformCorChromiumCGMac => useFullPlatformForChromiumCGMac ?
Ryosuke Niwa
Comment 3
2011-10-18 09:32:22 PDT
(In reply to
comment #2
)
> (From update of
attachment 111411
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=111411&action=review
> > Why don't we always pass the full platform?
I couldn't tell if full platform is supported for all ports or not. I'd rather not break other ports since I'd expect this work-around to go away once CG -> Skia transition is done.
> > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:91 > > +def appendCustomBuildFlags(step, platform, fullPlatform="", useFullPlatformCorChromiumCGMac=False): > > useFullPlatformCorChromiumCGMac => useFullPlatformForChromiumCGMac ?
Yeah, it's a typo.
Ryosuke Niwa
Comment 4
2011-10-18 09:35:15 PDT
Created
attachment 111452
[details]
fixed typo
Adam Barth
Comment 5
2011-10-18 09:38:01 PDT
Comment on
attachment 111452
[details]
fixed typo Can you add a FIXME comment about removing this once Skia is the default on Mac?
Ryosuke Niwa
Comment 6
2011-10-18 09:45:19 PDT
(In reply to
comment #5
)
> (From update of
attachment 111452
[details]
) > Can you add a FIXME comment about removing this once Skia is the default on Mac?
Good idea. Will do.
Ryosuke Niwa
Comment 7
2011-10-18 10:08:55 PDT
I guess I'll land this tonight when bots are quiet.
Ryosuke Niwa
Comment 8
2011-10-18 12:23:38 PDT
Committed
r97781
: <
http://trac.webkit.org/changeset/97781
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug