Bug 70310 - [EFL] Added missing dummy platformDescription function
Summary: [EFL] Added missing dummy platformDescription function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-17 23:51 PDT by Tomasz Morawski
Modified: 2011-10-19 00:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.35 KB, patch)
2011-10-17 23:53 PDT, Tomasz Morawski 		no flags Details | Formatted Diff | Diff
Patch 2 (1.22 KB, patch)
2011-10-18 00:33 PDT, Tomasz Morawski 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Morawski 2011-10-17 23:51:38 PDT 
Added dummy platformDescription function needed to compile WK2.
Comment 1 Tomasz Morawski 2011-10-17 23:53:23 PDT 
Created attachment 111395 [details]
Patch
Comment 2 Gyuyoung Kim 2011-10-18 00:24:12 PDT 
Comment on attachment 111395 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111395&action=review

> Source/WebCore/platform/efl/ContextMenuEfl.cpp:23
> +

Why do you add an empty line to here?

> Source/WebCore/platform/efl/ContextMenuEfl.cpp:52
> +

It looks unneeded an empty line.
Comment 3 Tomasz Morawski 2011-10-18 00:33:22 PDT 
Created attachment 111402 [details]
Patch 2
Comment 4 Gyuyoung Kim 2011-10-18 00:38:21 PDT 
Comment on attachment 111402 [details]
Patch 2

LGTM.
Comment 5 Leandro Pereira 2011-10-18 06:28:48 PDT 
Comment on attachment 111402 [details]
Patch 2

LGTM.
Comment 6 WebKit Review Bot 2011-10-19 00:17:07 PDT 
Comment on attachment 111402 [details]
Patch 2

Clearing flags on attachment: 111402

Committed r97837: <http://trac.webkit.org/changeset/97837>
Comment 7 WebKit Review Bot 2011-10-19 00:17:12 PDT 
All reviewed patches have been landed.  Closing bug.