Bug 70294 - platform/chromium/compositing/plugins/webplugin* failing on cg snowleopard
Summary: platform/chromium/compositing/plugins/webplugin* failing on cg snowleopard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-17 18:47 PDT by Dirk Pranke
Modified: 2011-12-19 11:12 PST (History)
3 users (show)

See Also:


Attachments
Patch (3.42 KB, patch)
2011-10-17 18:57 PDT, Dirk Pranke
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2011-10-17 18:47:49 PDT
The new tests added in http://trac.webkit.org/changeset/97678 (bug 69027) are failing in the CG Snow Leopard GPU path. We don't seem to have a chromium-gpu-cg-macsnowleopard directory, so I'll assume any baselines should go into chromium-gpu-cg-mac . 

It looks like they just need new baselines, but I'm filing this in case I am mistaken.

Also, for some reason, rebaseline-chromium-webkit-tests doesn't seem to be handling the archives properly (need to dig into this further).
Comment 1 Dirk Pranke 2011-10-17 18:57:27 PDT
Created attachment 111368 [details]
Patch
Comment 2 Dirk Pranke 2011-10-17 19:02:04 PDT
Committed r97699: <http://trac.webkit.org/changeset/97699>
Comment 3 Alok Priyadarshi 2011-10-18 09:54:19 PDT
There are TEXT differences. RenderBody height differs by one pixel. Is this expected?
Comment 4 Dirk Pranke 2011-10-18 19:05:09 PDT
Good question. I don't know. It was your change, though, so you tell me ...
Comment 5 Eric Seidel (no email) 2011-12-19 11:12:50 PST
Comment on attachment 111368 [details]
Patch

Cleared review? from attachment 111368 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).