Bug 70281 - Rename static put to putByIndex
Summary: Rename static put to putByIndex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 67690
  Show dependency treegraph
 
Reported: 2011-10-17 16:06 PDT by Mark Hahnenberg
Modified: 2011-10-18 16:52 PDT (History)
1 user (show)

See Also:


Attachments
Patch (22.97 KB, patch)
2011-10-17 16:10 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-10-17 16:06:17 PDT
There are two versions of put, one that uses an Identifier and the other that uses an unsigned.  We need to rename the version that takes an unsigned to putByIndex.  This is in preparation for adding both versions to the MethodTable.
Comment 1 Mark Hahnenberg 2011-10-17 16:10:15 PDT
Created attachment 111340 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-17 16:12:14 PDT
Attachment 111340 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
	M	LayoutTests/platform/chromium/test_expectations.txt
	M	LayoutTests/ChangeLog
r97663 = 5dde0580a24b0fb1bb50d10ae91b5d1b3cc66d66 (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2011-10-18 15:50:35 PDT
Comment on attachment 111340 [details]
Patch

r=me
Comment 4 WebKit Review Bot 2011-10-18 16:52:51 PDT
Comment on attachment 111340 [details]
Patch

Clearing flags on attachment: 111340

Committed r97817: <http://trac.webkit.org/changeset/97817>
Comment 5 WebKit Review Bot 2011-10-18 16:52:55 PDT
All reviewed patches have been landed.  Closing bug.