Bug 70276 – Remove OptionElement (first half)

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Darin Adler]

Remove OptionElement (first half)

[Darin Adler]

Created attachment 111336 [details]
Patch

[WebKit Review Bot]

Attachment 111336 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 111336 [details]
Patch

Attachment 111336 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10102320

[Gyuyoung Kim]

Comment on attachment 111336 [details]
Patch

Attachment 111336 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10120022

[Darin Adler]

Created attachment 111347 [details]
Patch

[Early Warning System Bot]

Comment on attachment 111347 [details]
Patch

Attachment 111347 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10124027

[Gyuyoung Kim]

Comment on attachment 111347 [details]
Patch

Attachment 111347 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10126035

[WebKit Review Bot]

Comment on attachment 111347 [details]
Patch

Attachment 111347 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10120088

[Kent Tamura]

Comment on attachment 111347 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111347&action=review

r- because of build failures.

> Source/WebCore/html/HTMLOptionElement.cpp:42
> +#include "StringBuilder.h"

Should be <wtf/text/StringBuilder.h>

> Source/WebCore/html/HTMLOptionElement.cpp:170
> +    int length = items.size();

nit: length should be size_t.

> Source/WebCore/html/HTMLOptionElement.cpp:315
> +    for (Node* n = firstChild(); n; ) {

nit: One-letter variable name is not good.

> Source/WebCore/html/HTMLSelectElement.cpp:78
> +static inline HTMLOptionElement* toOptionElement(Element* element)

This function name is confusing.  This looks like toClassName() which we use for many classes, but there is no OptionElement class and toClassName() usually returns no 0.
Do you have a plan to remove/rename this?

[Darin Adler]

(In reply to comment #9)
> > Source/WebCore/html/HTMLOptionElement.cpp:315
> > +    for (Node* n = firstChild(); n; ) {
> 
> nit: One-letter variable name is not good.

I just moved that code, but I would be happy to give it a better name.

> > Source/WebCore/html/HTMLSelectElement.cpp:78
> > +static inline HTMLOptionElement* toOptionElement(Element* element)
> 
> This function name is confusing.  This looks like toClassName() which we use for many classes, but there is no OptionElement class and toClassName() usually returns no 0.
> Do you have a plan to remove/rename this?

Yes. I’ll do that in the second half.

[Darin Adler]

Thanks for the review, by the way. I’ll try to upload a new cut at this soon.

[Darin Adler]

Created attachment 111510 [details]
Patch

[Kent Tamura]

Comment on attachment 111510 [details]
Patch

ok

[WebKit Review Bot]

Comment on attachment 111510 [details]
Patch

Rejecting attachment 111510 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
omium/src/WebOptionElement.cpp: In member function 'void WebKit::WebOptionElement::setDefaultSelected(bool)':
Source/WebKit/chromium/src/WebOptionElement.cpp:71: error: 'class WebCore::HTMLOptionElement' has no member named 'setDefaultSelected'
Source/WebKit/chromium/src/WebOptionElement.cpp:71: error: return-statement with a value, in function returning 'void'
make: *** [out/Debug/obj.target/webkit/Source/WebKit/chromium/src/WebOptionElement.o] Error 1
make: *** Waiting for unfinished jobs....

Full output: http://queues.webkit.org/results/10138144

[WebKit Review Bot]

Comment on attachment 111510 [details]
Patch

Attachment 111510 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10138163

[Darin Adler]

Created attachment 111540 [details]
Patch

[WebKit Review Bot]

Comment on attachment 111540 [details]
Patch

Attachment 111540 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10143189

[Darin Adler]

Created attachment 111657 [details]
Patch

[Kent Tamura]

Comment on attachment 111657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111657&action=review

> Source/WebKit/chromium/src/WebOptionElement.cpp:72
> -    return unwrap<HTMLOptionElement>()->setDefaultSelected(newSelected);
> +    return unwrap<HTMLOptionElement>()->setAttribute(selectedAttr, newSelected ? "" : 0);

Probably we can use setBooleanAttribute().

[Darin Adler]

setBooleanAttribute is a good idea. I had forgotten it existed!

[WebKit Review Bot]

Comment on attachment 111657 [details]
Patch

Clearing flags on attachment: 111657

Committed r97917: <http://trac.webkit.org/changeset/97917>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kent Tamura]

Comment on attachment 111657 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111657&action=review

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:190
> -    RetainPtr<CGImageRef> image = copyNativeImage(copyBehavior);
> +    RetainPtr<CGImageRef> image(AdoptCF, copyNativeImage(copyBehavior));

Wow, this is unrelated to this bug.

[Kent Tamura]

http://trac.webkit.org/changeset/97917 was rolled out.

[Darin Adler]

Would have been much better to roll out that one unrelated line rather than rolling out the whole patch.

[Darin Adler]

Committed r98053: <http://trac.webkit.org/changeset/98053>