Bug 70272 - Rename deregister* to unregister*
Summary: Rename deregister* to unregister*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-17 14:44 PDT by Ryosuke Niwa
Modified: 2011-10-17 20:11 PDT (History)
7 users (show)

See Also:


Attachments
cleanup (4.32 KB, patch)
2011-10-17 14:49 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-10-17 14:44:58 PDT
There are exactly 3 functions in Source named deregisterBlah instead of unregisterBlah. We should rename them all to unregisteredBlah for consistency.
Comment 1 Ryosuke Niwa 2011-10-17 14:45:12 PDT
Source/JavaScriptCore/runtime/JSGlobalObject.h:        void deregisterWeakMap(OpaqueJSWeakObjectMap* map)
Source/WebCore/inspector/front-end/ExtensionAPI.js:            extensionServer.deregisterHandler("open-resource");
Source/WebCore/inspector/front-end/ExtensionAPI.js:    deregisterHandler: function(command)
Source/WebCore/inspector/front-end/ExtensionServer.js:            WebInspector.openAnchorLocationRegistry.deregisterHandler(name);
Source/WebCore/inspector/front-end/HandlerRegistry.js:    deregisterHandler: function(name)
Comment 2 Ryosuke Niwa 2011-10-17 14:49:35 PDT
Created attachment 111324 [details]
cleanup
Comment 3 WebKit Review Bot 2011-10-17 14:51:57 PDT
Attachment 111324 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒0﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒1﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒2﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Review Bot 2011-10-17 20:11:21 PDT
Comment on attachment 111324 [details]
cleanup

Clearing flags on attachment: 111324

Committed r97706: <http://trac.webkit.org/changeset/97706>
Comment 5 WebKit Review Bot 2011-10-17 20:11:26 PDT
All reviewed patches have been landed.  Closing bug.