RESOLVED FIXED 70272
Rename deregister* to unregister*
https://bugs.webkit.org/show_bug.cgi?id=70272
Summary Rename deregister* to unregister*
Ryosuke Niwa
Reported 2011-10-17 14:44:58 PDT
There are exactly 3 functions in Source named deregisterBlah instead of unregisterBlah. We should rename them all to unregisteredBlah for consistency.
Attachments
cleanup (4.32 KB, patch)
2011-10-17 14:49 PDT, Ryosuke Niwa
no flags
Ryosuke Niwa
Comment 1 2011-10-17 14:45:12 PDT
Source/JavaScriptCore/runtime/JSGlobalObject.h: void deregisterWeakMap(OpaqueJSWeakObjectMap* map) Source/WebCore/inspector/front-end/ExtensionAPI.js: extensionServer.deregisterHandler("open-resource"); Source/WebCore/inspector/front-end/ExtensionAPI.js: deregisterHandler: function(command) Source/WebCore/inspector/front-end/ExtensionServer.js: WebInspector.openAnchorLocationRegistry.deregisterHandler(name); Source/WebCore/inspector/front-end/HandlerRegistry.js: deregisterHandler: function(name)
Ryosuke Niwa
Comment 2 2011-10-17 14:49:35 PDT
WebKit Review Bot
Comment 3 2011-10-17 14:51:57 PDT
Attachment 111324 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Review Bot
Comment 4 2011-10-17 20:11:21 PDT
Comment on attachment 111324 [details] cleanup Clearing flags on attachment: 111324 Committed r97706: <http://trac.webkit.org/changeset/97706>
WebKit Review Bot
Comment 5 2011-10-17 20:11:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.