Bug 70272 – Rename deregister* to unregister*

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ryosuke Niwa]

There are exactly 3 functions in Source named deregisterBlah instead of unregisterBlah. We should rename them all to unregisteredBlah for consistency.

[Ryosuke Niwa]

Source/JavaScriptCore/runtime/JSGlobalObject.h:        void deregisterWeakMap(OpaqueJSWeakObjectMap* map)
Source/WebCore/inspector/front-end/ExtensionAPI.js:            extensionServer.deregisterHandler("open-resource");
Source/WebCore/inspector/front-end/ExtensionAPI.js:    deregisterHandler: function(command)
Source/WebCore/inspector/front-end/ExtensionServer.js:            WebInspector.openAnchorLocationRegistry.deregisterHandler(name);
Source/WebCore/inspector/front-end/HandlerRegistry.js:    deregisterHandler: function(name)

[Ryosuke Niwa]

Created attachment 111324 [details]
cleanup

[WebKit Review Bot]

Attachment 111324 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Review Bot]

Comment on attachment 111324 [details]
cleanup

Clearing flags on attachment: 111324

Committed r97706: <http://trac.webkit.org/changeset/97706>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.