Bug 70267 – CodeGeneratorGObject.pm should use g_value_get_uint() for IDL attributes of type unsigned short.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Anna Cavender]

GetGValueTypeName() in CodeGeneratorGObject converts writable attributes of type unsigned short to g_value_get_ushort(), which is a function that does not exist!  I propose changing it to instead generate g_value_get_uint(), which does exist, when it sees this type.  I think this is a ligit change because GetGValueTypeName() already converts 'short' to 'int', so converting 'unsigned short' to 'uint' seems reasonable.

For more info and an example, see https://bugs.webkit.org/show_bug.cgi?id=62887

[Anna Cavender]

Created attachment 111315 [details]
Patch

[WebKit Review Bot]

Attachment 111315 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 111315 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111315&action=review

> Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:1583
> -G_MAXUINT16, /* max */
> +G_MAXUINT, /* max */

Would it make more sense to use G_MAXUSHORT here?

[Martin Robinson]

By the way, thanks for fixing this. I really appreciate it!

[Xan Lopez]

Comment on attachment 111315 [details]
Patch

This makes sense to me with Martin's suggestion. Thanks for the patch!

[Anna Cavender]

Thanks for the quick review.  I'll change to G_MAXUSHORT and then land.

[Anna Cavender]

Created attachment 111454 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 111454 [details]
Patch for landing

Rejecting attachment 111454 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

NOBODY (OOPS!) found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/10124298

[Anna Cavender]

Created attachment 111456 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 111456 [details]
Patch for landing

Clearing flags on attachment: 111456

Committed r97778: <http://trac.webkit.org/changeset/97778>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Ryosuke Niwa]

It appears that this patch broke binding tests:
http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/34000

[Anna Cavender]

Oops, looks like G_MAXUINT is required by the test, not G_MAXUSHORT.  New patch on the way.

[Anna Cavender]

Created attachment 111482 [details]
fix for binding tests

[Anna Cavender]

needs fix for binding tests

[WebKit Review Bot]

Comment on attachment 111482 [details]
fix for binding tests

Rejecting attachment 111482 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
l Bates', u'--for..." exit_code: 1

Parsed 2 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp
Hunk #1 FAILED at 1580.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Daniel Bates', u'--for..." exit_code: 1

Full output: http://queues.webkit.org/results/10142103

[Anna Cavender]

Landed by hand:
http://trac.webkit.org/changeset/97793