Bug 70257 – Rename static deleteProperty to deletePropertyByIndex

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Hahnenberg]

There are two versions of deleteProperty, one that uses an Identifier and the other that uses an unsigned.  When we override only one of those versions in a class, the other name in the parent class is hidden.  In order to avoid this when defining the MethodTable for such a class, we need give distinct names to each version.  We will rename the version that takes an unsigned to deletePropertyByIndex.  This will also be a good change because the way in which clients invoke functions in the MethodTable will match their actual declarations (since each entry in the MethodTable also needs a unique name).

[Mark Hahnenberg]

Created attachment 111312 [details]
Patch

[WebKit Review Bot]

Attachment 111312 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
From git://git.webkit.org/WebKit
   b2fbe31..928c0b6  master     -> origin/master
	M	Source/JavaScriptCore/runtime/Structure.h
	M	Source/JavaScriptCore/runtime/WriteBarrier.h
	M	Source/JavaScriptCore/runtime/JSObject.h
	M	Source/JavaScriptCore/runtime/JSObject.cpp
	M	Source/JavaScriptCore/runtime/JSArray.h
	M	Source/JavaScriptCore/runtime/JSArray.cpp
	M	Source/JavaScriptCore/ChangeLog
	M	Source/JavaScriptCore/JavaScriptCore.exp
	M	Source/JavaScriptCore/heap/SlotVisitor.h
	M	Source/JavaScriptCore/heap/HeapRootVisitor.h
	M	Source/JavaScriptCore/heap/Heap.cpp
	M	Source/JavaScriptCore/heap/MarkStack.cpp
	M	Source/JavaScriptCore/heap/HandleStack.cpp
	M	Source/JavaScriptCore/heap/MarkStack.h
r97642 = 3a7b479fc5c50d3b73427fb39b538f77e3c2a079 (refs/remotes/trunk)
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/page/Frame.cpp
	M	Source/WebCore/page/DOMWindow.h
	M	Source/WebCore/page/DOMWindow.cpp
	M	Source/WebCore/notifications/NotificationCenter.cpp
	A	Source/WebCore/manual-tests/iframe_notifications/iframe-reparenting-close-window.html
	A	Source/WebCore/manual-tests/iframe_notifications/iframe-reparenting-close-window-child.html
	A	Source/WebCore/manual-tests/iframe_notifications/iframe-reparenting-close-window-iframe.html
r97643 = 928c0b66202c13784242f405cda156284c4eddea (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 111312 [details]
Patch

r=me

[WebKit Review Bot]

Comment on attachment 111312 [details]
Patch

Rejecting attachment 111312 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
n/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/10176114

[Mark Hahnenberg]

Committed r98002: <http://trac.webkit.org/changeset/98002>