RESOLVED FIXED 70254
[Qt] Support WK1-only Skipped list
https://bugs.webkit.org/show_bug.cgi?id=70254
Summary [Qt] Support WK1-only Skipped list
Chang Shu
Reported 2011-10-17 11:58:06 PDT
As the development of new features may focus on WK2 only, some layout tests may work on WK2 but fail on WK1. Currently, all skipped WK1 tests are also skipped on WK2. We should create a mechanism to allow tests skip on WK1 but run on WK2.
Attachments
patch 1 (2.05 KB, patch)
2011-10-17 12:04 PDT, Chang Shu
no flags
patch 2 (2.96 KB, patch)
2011-10-17 13:39 PDT, Chang Shu
no flags
patch 3: update per review (2.88 KB, patch)
2011-10-18 07:02 PDT, Chang Shu
no flags
Chang Shu
Comment 1 2011-10-17 12:04:20 PDT
Created attachment 111295 [details] patch 1 We don't seem have to implement any code for baseline results at the moment.
WebKit Review Bot
Comment 2 2011-10-17 12:06:18 PDT
Attachment 111295 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
Chang Shu
Comment 3 2011-10-17 13:39:27 PDT
Created attachment 111311 [details] patch 2 add ORWT support
WebKit Review Bot
Comment 4 2011-10-17 13:41:28 PDT
Attachment 111311 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
Csaba Osztrogonác
Comment 5 2011-10-18 01:03:25 PDT
Comment on attachment 111311 [details] patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=111311&action=review > Tools/Scripts/old-run-webkit-tests:2478 > + # Add Qt WK1-only skipped tests. > + push(@skippedFileDirectories, catdir($platformBaseDirectory, "qt-wk1")) if ($platform eq "qt-linux"); I think (isQt() && !$useWebKitTestRunner) condition would be better than ($platform eq "qt-linux"), but I'm not sure if isQt() is absolutely correct now.
Chang Shu
Comment 6 2011-10-18 07:02:01 PDT
Created attachment 111436 [details] patch 3: update per review
Csaba Osztrogonác
Comment 7 2011-10-19 08:24:55 PDT
Comment on attachment 111436 [details] patch 3: update per review LGTM, r=me, but cq-, because commit queue still hates me. Please watch the bots and roll-out if something goes wrong.
Chang Shu
Comment 8 2011-10-19 08:36:51 PDT
Comment on attachment 111436 [details] patch 3: update per review Clearing flags on attachment: 111436 Committed r97866: <http://trac.webkit.org/changeset/97866>
Chang Shu
Comment 9 2011-10-19 08:36:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.