Bug 70249 - garden-o-matic operations fail because of CSP.
Summary: garden-o-matic operations fail because of CSP.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 64182
  Show dependency treegraph
 
Reported: 2011-10-17 11:12 PDT by Dimitri Glazkov (Google)
Modified: 2011-10-17 11:16 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.91 KB, patch)
2011-10-17 11:12 PDT, Dimitri Glazkov (Google)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-10-17 11:12:25 PDT
garden-o-matic operations fail because of CSP.
Comment 1 Dimitri Glazkov (Google) 2011-10-17 11:12:59 PDT
Created attachment 111286 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-10-17 11:13:26 PDT
I am a CSP n00b, so I am not sure if this is the right fix. Please teach me :)
Comment 3 Adam Barth 2011-10-17 11:13:38 PDT
Comment on attachment 111286 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111286&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:37
> -                                         connect-src http://trac.webkit.org http://build.chromium.org">
> +                                         connect-src http://trac.webkit.org http://build.chromium.org http://127.0.0.1:8127/ping">

Just "http://127.0.0.1:8127" no /ping
Comment 4 WebKit Review Bot 2011-10-17 11:14:48 PDT
Attachment 111286 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒0﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒1﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒2﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Dimitri Glazkov (Google) 2011-10-17 11:16:18 PDT
Committed r97634: <http://trac.webkit.org/changeset/97634>
Comment 6 Dimitri Glazkov (Google) 2011-10-17 11:16:45 PDT
(In reply to comment #4)
> Attachment 111286 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2
> 
> Updating OpenSource
> Current branch master is up to date.
> Updating chromium port dependencies using gclient...
> Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒0﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
> Re-trying 'depot_tools/gclient sync'
> Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒1﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
> Re-trying 'depot_tools/gclient sync'
> Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒2﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
> Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
> Re-trying 'depot_tools/gclient sync'
> No such file or directory at Tools/Scripts/update-webkit line 104.
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Urrrk. This sounds unpleasant.