Bug 70243 - AX: children() method should be consolidated in AccessibilityObject
Summary: AX: children() method should be consolidated in AccessibilityObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on:
Blocks: 70241
  Show dependency treegraph
 
Reported: 2011-10-17 08:29 PDT by chris fleizach
Modified: 2011-10-17 10:00 PDT (History)
1 user (show)

See Also:


Attachments
patch (9.65 KB, patch)
2011-10-17 09:04 PDT, chris fleizach
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2011-10-17 08:29:58 PDT
Right now there are four or five nearly identical implementations of children(). 

Those can be consolidate into one method in AccessibilityObject
Comment 1 chris fleizach 2011-10-17 09:04:55 PDT
Created attachment 111270 [details]
patch
Comment 2 WebKit Review Bot 2011-10-17 09:07:26 PDT
Attachment 111270 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒0﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒1﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒2﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2011-10-17 09:13:32 PDT
Comment on attachment 111270 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111270&action=review

> Source/WebCore/accessibility/AccessibilityTableColumn.cpp:75
> + 

Stray blank space on what should just be an empty line.
Comment 4 chris fleizach 2011-10-17 10:00:49 PDT
http://trac.webkit.org/changeset/97629