Bug 70240 - Move CSSRule specific virtuals from StyleBase down into CSSRule.
Summary: Move CSSRule specific virtuals from StyleBase down into CSSRule.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-17 08:07 PDT by Andreas Kling
Modified: 2011-10-18 05:45 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch (4.17 KB, patch)
2011-10-17 08:11 PDT, Andreas Kling 		darin: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-10-17 08:07:23 PDT 
The isFooRule() virtuals and insertedIntoParent() can be moved down to CSSRule now.
Comment 1 Andreas Kling 2011-10-17 08:11:34 PDT 
Created attachment 111266 [details]
Proposed patch
Comment 2 WebKit Review Bot 2011-10-17 08:13:28 PDT 
Attachment 111266 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2011-10-17 08:31:01 PDT 
Comment on attachment 111266 [details]
Proposed patch

Attachment 111266 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10086090
Comment 4 Andreas Kling 2011-10-17 08:40:59 PDT 
(In reply to comment #3)
> (From update of attachment 111266 [details])
> Attachment 111266 [details] did not pass efl-ews (efl):
> Output: http://queues.webkit.org/results/10086090

D'oh. XSLImportRule still uses isImportRule().
Comment 5 Collabora GTK+ EWS bot 2011-10-17 12:51:58 PDT 
Comment on attachment 111266 [details]
Proposed patch

Attachment 111266 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10086597
Comment 6 WebKit Review Bot 2011-10-17 16:21:13 PDT 
Comment on attachment 111266 [details]
Proposed patch

Attachment 111266 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10120018
Comment 7 Andreas Kling 2011-10-18 05:45:10 PDT 
Committed r97742: <http://trac.webkit.org/changeset/97742>