RESOLVED INVALID70234
Web Inspector: make profiler front-end model closure compile. 
https://bugs.webkit.org/show_bug.cgi?id=70234
Summary Web Inspector: make profiler front-end model closure compile.
Pavel Feldman
Reported 2011-10-17 07:18:46 PDT
Patch to follow.
Attachments
Patch (37.44 KB, patch)
2011-10-17 09:15 PDT, Pavel Feldman 		yurys: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-10-17 09:15:43 PDT
Created attachment 111273 [details] Patch
WebKit Review Bot
Comment 2 2011-10-17 09:17:43 PDT
Attachment 111273 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
Mikhail Naganov
Comment 3 2011-10-17 10:03:21 PDT
Comment on attachment 111273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111273&action=review Looks good, 1 comment. > Source/WebCore/inspector/front-end/HeapSnapshot.js:-213 > - this.edgeIndex = edgeIndex || 0; Why don't you use a default value? They seem to be allowed in WebKit.
Pavel Feldman
Comment 4 2011-10-17 11:58:51 PDT
> > Source/WebCore/inspector/front-end/HeapSnapshot.js:-213 > > - this.edgeIndex = edgeIndex || 0; > > Why don't you use a default value? They seem to be allowed in WebKit. I am trying to minimuze optional parameters where possible. In this case, majority of call sites were passing explicit edgeIndex.
Yury Semikhatsky
Comment 5 2011-10-19 05:01:02 PDT
Comment on attachment 111273 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111273&action=review > Source/WebCore/inspector/Inspector.json:1962 > + "id": "NodeLayoutInfo", NodeLayoutInfo -> NodeMemoryLayoutInfo or something like that as layout is generally used in a different sense in WebCore. > Source/WebCore/inspector/front-end/HeapSnapshotProxy.js:108 > + this._worker = window.InspectorTest ? new WebInspector.HeapSnapshotRealWorker() : new WebInspector.HeapSnapshotFakeWorker(); The if branches are confused, r- for this.
Note You need to log in before you can comment on or make changes to this bug.