Bug 70229 - [Curl] ResourceHandleManager::startJob() for Data URLs is missing deref()
Summary: [Curl] ResourceHandleManager::startJob() for Data URLs is missing deref()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on: 173991
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-17 05:24 PDT by Jens
Modified: 2017-07-18 15:16 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jens 2011-10-17 05:24:24 PDT 
Hello All,

IMHO a deref() is missing for asynchronous jobs with data:// URLs.

In function ResourceHandleManager.cpp:
- function add() calls ref() on a new job and adds it to a list
- function startScheduledJobs() takes it from that list and calls startJob()
- function startJob() calls handleDataUrl() (for data:// URLs)

Shouldn't startJob() call deref() after handleDataUrl() returns?

Best regards,
Jens
Comment 1 Basuke Suzuki 2017-07-18 15:16:14 PDT 
Because of the new architecture, this bug is invalid.
Comment 2 Basuke Suzuki 2017-07-18 15:16:42 PDT 
https://bugs.webkit.org/show_bug.cgi?id=173991