Bug 70226 - CSS/XSLStyleSheet: Remove insert() and remove().
Summary: CSS/XSLStyleSheet: Remove insert() and remove().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-17 03:43 PDT by Andreas Kling
Modified: 2011-10-17 04:38 PDT (History)
0 users

See Also:

Attachments
Proposed patch (5.03 KB, patch)
2011-10-17 03:44 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-10-17 03:43:36 PDT 
These methods are internal to WebKit and not part of the CSSOM.
Comment 1 Andreas Kling 2011-10-17 03:44:47 PDT 
Created attachment 111240 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2011-10-17 03:47:09 PDT 
Comment on attachment 111240 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111240&action=review

> Source/WebCore/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).
> +

shouldn't you add some reasoning for the change?
Comment 3 Antti Koivisto 2011-10-17 03:54:53 PDT 
Comment on attachment 111240 [details]
Proposed patch

r=me, with changes discussed in irc:

Keep remove() so you don't need to use the external api functions for internal stuff.
Comment 4 Andreas Kling 2011-10-17 04:38:06 PDT 
Committed r97605: <http://trac.webkit.org/changeset/97605>