Bug 70220 – Remove OptionGroupElement

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Kent Tamura]

Remove OptionGroupElement

[Kent Tamura]

Created attachment 111224 [details]
Patch

[Collabora GTK+ EWS bot]

Comment on attachment 111224 [details]
Patch

Attachment 111224 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10079784

[Kent Tamura]

Created attachment 111225 [details]
Patch 2

GTK build fix

[Darin Adler]

Comment on attachment 111225 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=111225&action=review

> Source/WebCore/dom/OptionElement.cpp:112
> +    if (parentElement && isHTMLOptGroupElement(parentElement))

I’m not sure we should have a special function for this. Just doing hasTagName(optgroupTag) directly seems fine to me.

> Source/WebCore/html/HTMLOptGroupElement.cpp:147
> +    return node && node->isHTMLElement() && node->hasTagName(optgroupTag);

There is no need for the isHTMLElement check in this function. The hasTagName function already checks the namespace and will return false for non-HTMLElement.

> Source/WebCore/html/HTMLOptGroupElement.h:64
> +bool isHTMLOptGroupElement(const Node*);

As I said above, I am not sure we need a helper function. It’s the same thing as calling hasTagName(optgroupTag).

[Kent Tamura]

Thank you for reviewing.

Ok, I'll remove isHTMLOptGroupElement(), and land it.

[Kent Tamura]

Created attachment 111374 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 111374 [details]
Patch for landing

Clearing flags on attachment: 111374

Committed r97720: <http://trac.webkit.org/changeset/97720>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.