Bug 70210 - REGRESSION(r97566) fast/js/stack-overflow-arrity-catch.html fails
Summary: REGRESSION(r97566) fast/js/stack-overflow-arrity-catch.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Erik Arvidsson
URL:
Keywords:
Depends on: 69881
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-16 18:58 PDT by Kent Tamura
Modified: 2011-10-17 14:40 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.59 KB, patch)
2011-10-17 13:50 PDT, Erik Arvidsson
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-10-16 18:58:35 PDT
fast/js/stack-overflow-arrity-catch.html has been failing since r97566.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fjs%2Fstack-overflow-arrity-catch.html&showExpectations=true&showLargeExpectations=true

--- e:\b\build\slave\Webkit_Win\build\layout-test-results\fast/js/stack-overflow-arrity-catch-expected.txt 
+++ e:\b\build\slave\Webkit_Win\build\layout-test-results\fast/js/stack-overflow-arrity-catch-actual.txt 
@@ -3,6 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
+Should not get here #2!
 PASS gotRightCatch is true
 PASS successfullyParsed is true
Comment 1 Kent Tamura 2011-10-16 19:00:01 PDT
This looks v8-only.
Comment 2 Kent Tamura 2011-10-16 22:43:41 PDT
I confirmed that reverting the change for stack-overflow-arrity-catch.html in r97566 fixed the failure.

I have no idea why the following two lines affect the result :-D

<p id="description"></p>
<div id="console"></div>
Comment 3 Erik Arvidsson 2011-10-17 12:31:32 PDT
The thing that changed was that debug now calls a different function which makes its stack depth 2 instead of 1.

I'm not sure this has ever worked as expected for V8. It seems like the assumptions are JSC specific. Also, if I change the debug() calls to simple bool assignment and check the values after the stack overflow has been handled we always reach 'Should not get here #2!'. It seems like the call to debug throws when we are at the deepest allowed call stack already which explains why we didn't get any debug output from this before.

I'm going to clean up the test and add it to chromiums test expectations.
Comment 4 Erik Arvidsson 2011-10-17 13:50:19 PDT
Created attachment 111317 [details]
Patch
Comment 5 WebKit Review Bot 2011-10-17 13:52:32 PDT
Attachment 111317 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒0﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒1﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3﷒2﷓; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Erik Arvidsson 2011-10-17 14:40:37 PDT
Committed r97651: <http://trac.webkit.org/changeset/97651>